Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache: resolve to current host when host URL cannot be resolved #1352

Merged
merged 1 commit into from May 30, 2017

Conversation

mudler
Copy link
Member

@mudler mudler commented May 30, 2017

Meanwhile strictly check if we got asset size

See (possibly) related Progress issue: https://progress.opensuse.org/issues/19436

Meanwhile strictly check if we got asset size
@codecov
Copy link

codecov bot commented May 30, 2017

Codecov Report

Merging #1352 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1352      +/-   ##
==========================================
- Coverage   87.32%   87.32%   -0.01%     
==========================================
  Files         101      101              
  Lines        7450     7449       -1     
==========================================
- Hits         6506     6505       -1     
  Misses        944      944
Impacted Files Coverage Δ
lib/OpenQA/Worker/Cache.pm 77.25% <100%> (-0.11%) ⬇️
lib/OpenQA/Worker.pm 96.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49e14ec...6099e98. Read the comment docs.

@foursixnine
Copy link
Member

LGTM

@coolo coolo merged commit d9d39c5 into os-autoinst:master May 30, 2017
coolo pushed a commit that referenced this pull request May 30, 2017
commit d9d39c5
Author:     Ettore Di Giacinto <mudler@users.noreply.github.com>
AuthorDate: Tue May 30 20:57:45 2017 +0200
Commit:     Stephan Kulow <coolo@kde.org>
CommitDate: Tue May 30 20:57:45 2017 +0200

    Cache: resolve to current host when host URL cannot be resolved (#1352)

    Meanwhile strictly check if we got asset size
@mudler mudler deleted the hotfix_cache_size branch August 14, 2017 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants