Sync needles when caching is enabled

[foursixnine]

This is a quick try to solve poo#19408

A verification run: http://deimos.suse.de/tests/6104#step/bootloader/6 that's showing just the needle that was created in interactive mode.

[foursixnine]

I basically duplicated the code from isotovideo engine. May be it calls for refactoring, but for now it seems to do the job. /cc @okurz @Zaoliang

[sysrich]

As discussed with @foursixnine -1 from me

[okurz]

Great. You found a way to make it work and you know how to test. Now to reduce the duplication I suggest to implement that call as a isotovideo RPC command which can then be called from all locations where necessary.

[codecov]

Codecov Report

Merging #1381 into master will increase coverage by 13.19%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           master    #1381       +/-   ##
===========================================
+ Coverage   75.27%   88.47%   +13.19%     
===========================================
  Files         105      105               
  Lines        7936     7945        +9     
===========================================
+ Hits         5974     7029     +1055     
+ Misses       1962      916     -1046

Impacted Files	Coverage Δ
lib/OpenQA/Worker/Common.pm	80.93% <100%> (+35.82%)	⬆️
lib/OpenQA/Worker.pm	96.61% <100%> (+72.04%)	⬆️
lib/OpenQA/Worker/Commands.pm	76.66% <33.33%> (+24.28%)	⬆️
lib/OpenQA/WebAPI/Plugin/Helpers.pm	97.14% <0%> (+0.57%)	⬆️
lib/OpenQA/WebAPI.pm	92.18% <0%> (+2.28%)	⬆️
lib/OpenQA/Schema/Result/ScreenshotLinks.pm	39.62% <0%> (+5.66%)	⬆️
lib/OpenQA/Schema/Result/Needles.pm	79.04% <0%> (+5.71%)	⬆️
lib/OpenQA/WebAPI/Controller/API/V1/Job.pm	79.31% <0%> (+6.03%)	⬆️
lib/OpenQA/Utils.pm	90.65% <0%> (+7.16%)	⬆️
lib/OpenQA/Schema/Result/JobModules.pm	91.16% <0%> (+7.9%)	⬆️
... and 14 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a0fcfc...79add65. Read the comment docs.

[coolo]

Actually, interactive mode with caching is IMO just nice to have. So refactor with ease

[foursixnine]

Time to work on a full-stack-ui test suite?

[coolo]

the whole idea of the full stack test was born to be able to test the interactive mode at all. But I never came around it, because https://progress.opensuse.org/issues/14818 needs to be fixed first

[coolo]

but if you could put it in record: did you test this manually with and without caching enabled?

[foursixnine]

Yep, tested on both scenarios, no problems so far signs with blood
When caching is enabled, this will be the output:

[DEBUG] Calling flock /var/lib/openqa/cache/deimos.suse.de/needleslock rsync -avHP rsync://deimos.suse.de/openqa-tests/ --delete /var/lib/openqa/cache/deimos.suse.de/tests/
receiving incremental file list                                         
opensuse/products/sle/needles/                                                                                                         
opensuse/products/sle/needles/failed-to-boot-20170810.json                                                                             
            217 100%  211.91kB/s    0:00:00 (xfr#1, ir-chk=8438/16702)                                        
opensuse/products/sle/needles/failed-to-boot-20170810.png                                                                              
          1,193 100%    1.14MB/s    0:00:00 (xfr#2, ir-chk=8437/16702)                                                                                                                                                                                                         
                                                                                                                                                                                                                                                                               
sent 431 bytes  received 450,909 bytes  902,680.00 bytes/sec                                                                            
total size is 2,066,964,415  speedup is 4,579.62                                                                                                                                                               
[DEBUG] RSYNC: Synchronization of tests directory took 0.00 seconds                                                                                        
[DEBUG] needles will be reloaded

When it is disabled, it still is:
[DEBUG] needles will be reloaded

[okurz]

LGTM

[foursixnine]

Life is sexy again now, let's live with that small coverage drop for the time being, as we would need to improve the fullstack test to also cover the needle editor with and without caching.