-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description part for api routes at not_found page #1439
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1439 +/- ##
===========================================
+ Coverage 74.08% 87.55% +13.46%
===========================================
Files 105 105
Lines 7918 7921 +3
===========================================
+ Hits 5866 6935 +1069
+ Misses 2052 986 -1066
Continue to review full report at Codecov.
|
7ecb565
to
02637c6
Compare
02637c6
to
5d722f4
Compare
this really deserves a test case - and IMO a default. Most of the s will contain undef and IMO result in tons of warnings |
@krauselukas As @coolo already mentioned, this will produce tons of warnings if you don't check for undefined. Do you still have time to work on this? I'm asking since you changed the team. If not, I can take over if this approach for implementing better API documentation is desired. It actually goes into the same direction as I my proposal in the ticket (extending route introspection). |
@Martchus go for it, i planned to finish all my PR's, but this could take a while, so you are more then welcome to take over :) thank you! |
Ok, then I'll finish this. Shouldn't be much effort (only a few things to fix). |
Superseded by #1439 |
You mean by #1455 |
:P Yeah, that one :) |
Related to https://progress.opensuse.org/issues/16282
The thought was to make a first step relating this ticket and add a description part to the already existing api routes table on the not_found page.