Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description part for api routes at not_found page #1439

Closed

Conversation

krauselukas
Copy link
Contributor

@krauselukas krauselukas commented Aug 29, 2017

Related to https://progress.opensuse.org/issues/16282

The thought was to make a first step relating this ticket and add a description part to the already existing api routes table on the not_found page.

@codecov
Copy link

codecov bot commented Aug 29, 2017

Codecov Report

Merging #1439 into master will increase coverage by 13.46%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1439       +/-   ##
===========================================
+ Coverage   74.08%   87.55%   +13.46%     
===========================================
  Files         105      105               
  Lines        7918     7921        +3     
===========================================
+ Hits         5866     6935     +1069     
+ Misses       2052      986     -1066
Impacted Files Coverage Δ
lib/OpenQA/WebAPI.pm 91.93% <100%> (+2.03%) ⬆️
lib/OpenQA/WebAPI/Plugin/Helpers.pm 98.28% <0%> (+0.57%) ⬆️
lib/OpenQA/Schema/Result/ScreenshotLinks.pm 39.62% <0%> (+5.66%) ⬆️
lib/OpenQA/Schema/Result/Needles.pm 79.04% <0%> (+5.71%) ⬆️
lib/OpenQA/WebAPI/Controller/API/V1/Job.pm 79.31% <0%> (+6.03%) ⬆️
lib/OpenQA/Utils.pm 90.31% <0%> (+7.18%) ⬆️
lib/OpenQA/Schema/Result/JobModules.pm 91.16% <0%> (+7.9%) ⬆️
lib/OpenQA/Scheduler/FakeApp.pm 95.65% <0%> (+8.69%) ⬆️
lib/OpenQA/Schema/Result/Workers.pm 96.25% <0%> (+8.75%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af71d0a...5d722f4. Read the comment docs.

@krauselukas krauselukas changed the title WIP: Add description part for api routes at not_found page Add description part for api routes at not_found page Aug 30, 2017
@coolo
Copy link
Contributor

coolo commented Sep 4, 2017

this really deserves a test case - and IMO a default. Most of the s will contain undef and IMO result in tons of warnings

@Martchus
Copy link
Contributor

@krauselukas As @coolo already mentioned, this will produce tons of warnings if you don't check for undefined. Do you still have time to work on this? I'm asking since you changed the team.

If not, I can take over if this approach for implementing better API documentation is desired. It actually goes into the same direction as I my proposal in the ticket (extending route introspection).

@krauselukas
Copy link
Contributor Author

@Martchus go for it, i planned to finish all my PR's, but this could take a while, so you are more then welcome to take over :) thank you!

@Martchus
Copy link
Contributor

Ok, then I'll finish this. Shouldn't be much effort (only a few things to fix).

@foursixnine
Copy link
Member

Superseded by #1439

@Martchus
Copy link
Contributor

You mean by #1455

@foursixnine
Copy link
Member

:P Yeah, that one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants