Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat ASSIGNED state as in execution #1447

Merged
merged 1 commit into from Sep 12, 2017
Merged

Conversation

mudler
Copy link
Member

@mudler mudler commented Sep 7, 2017

Add ASSIGNED state inside EXECUTION_STATES, allowing the job to be
restarted when stuck

So it will look like:

2017-09-07-113212_5760x1200_scrot

See related Progress issue: https://progress.opensuse.org/issues/23378

@coolo
Copy link
Contributor

coolo commented Sep 7, 2017

while you are at, also change running.js to poll assigned jobs :)

@mudler
Copy link
Member Author

mudler commented Sep 7, 2017

@coolo i would, but i'm not sure about js too much, afaics https://github.com/os-autoinst/openQA/blob/master/assets/javascripts/running.js#L17 should already handle it, no?

@codecov
Copy link

codecov bot commented Sep 7, 2017

Codecov Report

Merging #1447 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1447     +/-   ##
=========================================
- Coverage   88.14%   88.04%   -0.1%     
=========================================
  Files         105      105             
  Lines        7927     8008     +81     
=========================================
+ Hits         6987     7051     +64     
- Misses        940      957     +17
Impacted Files Coverage Δ
lib/OpenQA/Schema/Result/Jobs.pm 90.67% <100%> (ø) ⬆️
lib/OpenQA/Worker/Common.pm 77.35% <0%> (-3.08%) ⬇️
lib/OpenQA/WebSockets/Server.pm 90.24% <0%> (-0.49%) ⬇️
lib/OpenQA/WebAPI/Controller/Test.pm 99.08% <0%> (-0.23%) ⬇️
lib/OpenQA/Worker/Pool.pm 88.88% <0%> (+0.65%) ⬆️
lib/OpenQA/Worker/Commands.pm 80.89% <0%> (+1.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c421a8...4eb1114. Read the comment docs.

@coolo
Copy link
Contributor

coolo commented Sep 7, 2017

that function is not called as:

  if (state == "running" || state == "waiting" || state == "uploading") {
    setupRunning(jobid, status_url, details_url);
  }

Add ASSIGNED state inside EXECUTION_STATES, allowing the job to be
restarted when stuck

See related Progress issue: https://progress.opensuse.org/issues/23378
@mudler
Copy link
Member Author

mudler commented Sep 7, 2017

Closing, superseeded by #1446

@mudler mudler closed this Sep 7, 2017
@foursixnine foursixnine reopened this Sep 12, 2017
@foursixnine
Copy link
Member

Reopening due to #1446 not being done yet

@foursixnine
Copy link
Member

I don't get the unexpected coverage change thing

@mudler
Copy link
Member Author

mudler commented Sep 12, 2017

Current coverage is low due to a CI fail - https://codecov.io/gh/os-autoinst/openQA and lead #1452 to an amazing green 😄

@foursixnine foursixnine merged commit b39ef68 into os-autoinst:master Sep 12, 2017
coolo pushed a commit that referenced this pull request Sep 12, 2017
commit b39ef68
Merge: 90a6dae 4eb1114
Author:     Santiago Zarate <santiago@zarate.net.ve>
AuthorDate: Tue Sep 12 11:19:52 2017 +0200
Commit:     GitHub <noreply@github.com>
CommitDate: Tue Sep 12 11:19:52 2017 +0200

    Merge pull request #1447 from mudler/master

    Treat ASSIGNED state as in execution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants