Extend apparmor permissions for /usr/share/openqa/lib/** #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just glob all of /usr/share/openqa/lib |
mudler
force-pushed
the
apparmor_permissions
branch
from
72eec56
to
b17140d
Compare
See related Progress issue: https://progress.opensuse.org/issues/27934
mudler
force-pushed
the
apparmor_permissions
branch
from
b17140d
to
88e7cd7
Compare
mudler
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1504 +/- ##
=======================================
Coverage 88.47% 88.47%
=======================================
Files 106 106
Lines 8086 8086
=======================================
Hits 7154 7154
Misses 932 932
Continue to review full report at Codecov.
|
coolo
reviewed
Nov 22, 2017
| @@ -100,7 +100,7 @@ | |||
| /usr/sbin/ipmiconsole rix, | |||
| /usr/share/openqa/lib/DBIx/Class/Timestamps.pm r, | |||
| /usr/share/openqa/lib/OpenQA/** r, | |||
| /usr/share/openqa/lib/db_helpers.pm r, | |||
| /usr/share/openqa/lib/** r, | |||
There was a problem hiding this comment.
I think this covers also the 2 lines above, but let's leave it as is
|
LGTM It fixes poo#27934 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See related Progress issue: https://progress.opensuse.org/issues/27934