Allow same group name within different parent groups #1507
Conversation
|
please add a test case to verify we can have now groups with different parents but same name. |
mitiao
changed the title
|
This will likely work, as far as I know the name is really just used for display purposes. But yes, you should provide a test. Just add a few more lines in the tests we already have, eg. |
|
@Martchus thanks for your advice. |
|
You could use PhantomJS instead of Chromium. Just ensure the Note that I'm using Chromium and not Chrome. As far as I remember, I had to install the driver through a separate package under Tumbleweed. So maybe just a package missing? |
|
phantomjs support is dead - as IS SELENIUM_CHROME |
|
I'm sometimes still using it and it works (beside on particular line in one particular test). So it is worth a try as a workaround. Beside, things might get better when next PhantomJS version is released. It will use Qt WebKit ng/revived (or whatever they want to call it now). |
Codecov Report
@@ Coverage Diff @@
## master #1507 +/- ##
==========================================
+ Coverage 88.2% 88.31% +0.11%
==========================================
Files 106 106
Lines 8173 8149 -24
==========================================
- Hits 7209 7197 -12
+ Misses 964 952 -12
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1507 +/- ##
===========================================
- Coverage 87.37% 73.15% -14.22%
===========================================
Files 106 96 -10
Lines 8173 7682 -491
===========================================
- Hits 7141 5620 -1521
- Misses 1032 2062 +1030
Continue to review full report at Codecov.
|
mitiao
changed the title
|
|
||
| return 0 if $self->is_parent; | ||
| my $properties = $self->load_properties; | ||
| return $self->resultset->search({name => $properties->{'name'}, parent_id => undef}); |
There was a problem hiding this comment.
JobGroup.pm: Hash key with quotes at line 102, column 60. Avoid useless quotes. (Severity: 5)
|
the test cases are problematic at the moment, but the ui tests passed, so we should be fine |
commit 359a8b2 Author: Wei Jiang <mitiao@gmail.com> AuthorDate: Sat Dec 2 02:56:27 2017 +0800 Commit: Stephan Kulow <stephan@kulow.org> CommitDate: Fri Dec 1 19:56:27 2017 +0100 Allow same group name within different parent groups (#1507) See: https://progress.opensuse.org/issues/17846
see: https://progress.opensuse.org/issues/17846
feedback and advices please