Fix job group update issue #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1533 +/- ##
==========================================
+ Coverage 87.87% 87.95% +0.07%
==========================================
Files 106 106
Lines 8223 8225 +2
==========================================
+ Hits 7226 7234 +8
+ Misses 997 991 -6
Continue to review full report at Codecov.
|
coolo
requested changes
Dec 8, 2017
|
|
||
| return 0 if $self->is_parent; | ||
| my $properties = $self->load_properties; | ||
| return $self->resultset->search({name => $properties->{name}, parent_id => undef}); | ||
| unless ($group_id) { | ||
| return $self->resultset->search({name => $properties->{name}, parent_id => undef}); |
There was a problem hiding this comment.
please don't duplicate so much code. the argument to search is a hash and it's only different in one key.
coolo
reviewed
Dec 11, 2017
| return $self->resultset->search({name => $properties->{name}, parent_id => undef}); | ||
| my $conditions = {name => $properties->{name}, parent_id => undef}; | ||
| unless ($group_id) { | ||
| return $self->resultset->search($conditions); |
There was a problem hiding this comment.
now this line is the same as 3 lines later. So please just move the $conditions->{id} = into an if - and return the search uncondiotionally
coolo
approved these changes
Dec 11, 2017
coolo
pushed a commit
that referenced
this pull request
Dec 11, 2017
commit 63e3526 Author: Wei Jiang <mitiao@gmail.com> AuthorDate: Mon Dec 11 16:44:30 2017 +0800 Commit: Stephan Kulow <stephan@kulow.org> CommitDate: Mon Dec 11 09:44:30 2017 +0100 Fix job group update issue (#1533) See: https://progress.opensuse.org/issues/29110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://progress.opensuse.org/issues/29110