Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _source field to every detail generated by parsers implementations #1647

Merged
merged 1 commit into from May 11, 2018

Conversation

mudler
Copy link
Member

@mudler mudler commented May 9, 2018

Overload constructor and do apply the custom _source field to all parser formats details using Result::OpenQA

I'm testing this on staging, but should not have any regression, this should help #1639 to figure out which details were generated by the parser

Overload constructor and do apply the custom field to all parsers using Result::OpenQA
@Martchus
Copy link
Contributor

Martchus commented May 9, 2018

I haven't looked at the code yet, but I say already thanks :-)

@Martchus
Copy link
Contributor

Martchus commented May 9, 2018

Why the underscore? There's nothing to hide here.

@foursixnine
Copy link
Member

foursixnine commented May 9, 2018

@Martchus I suggested that to @mudler as source is more likely to be used by somebody else than _source :)

@codecov
Copy link

codecov bot commented May 9, 2018

Codecov Report

Merging #1647 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1647      +/-   ##
==========================================
+ Coverage   88.92%   88.97%   +0.04%     
==========================================
  Files         131      131              
  Lines        9418     9420       +2     
==========================================
+ Hits         8375     8381       +6     
+ Misses       1043     1039       -4
Impacted Files Coverage Δ
lib/OpenQA/Parser/Result/OpenQA.pm 100% <100%> (ø) ⬆️
lib/OpenQA/Task/Asset/Limit.pm 92.59% <0%> (-3.71%) ⬇️
lib/OpenQA/Worker/Engines/isotovideo.pm 94.51% <0%> (-1.22%) ⬇️
lib/OpenQA/Utils.pm 93.1% <0%> (-0.23%) ⬇️
lib/OpenQA/Worker/Common.pm 83.75% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f6bb61...6d49109. Read the comment docs.

@mudler
Copy link
Member Author

mudler commented May 10, 2018

@Martchus no problem, for the _source field it's like @foursixnine says

Tested on staging: http://e122.suse.de/tests/18917#step/2_tcpdmatch/6 ,

e.g.

[{"result":"ok","text":"tests-systemd-4_testing_services-1.txt","needles":[],"_source":"parser","title":"test simple service"},{"title":"test unstoppable service","_source":"parser","text":"tests-systemd-4_testing_services-2.txt","needles":[],"result":"ok"},{"text":"tests-systemd-4_testing_services-3.txt","needles":[],"result":"ok","title":"cancel queued job","_source":"parser"},{"text":"tests-systemd-4_testing_services-4.txt","needles":[],"result":"ok","_source":"parser","title":"cancel new jobs"}]

@coolo coolo merged commit 1ad9148 into os-autoinst:master May 11, 2018
coolo pushed a commit that referenced this pull request May 11, 2018
commit 1ad9148
Author:     Ettore Di Giacinto <mudler@users.noreply.github.com>
AuthorDate: Fri May 11 12:17:30 2018 +0200
Commit:     Stephan Kulow <stephan@kulow.org>
CommitDate: Fri May 11 12:17:30 2018 +0200

    Add _source field to every detail generated by parsers implementations (#1647)

    Overload constructor and do apply the custom field to all parsers using Result::OpenQA
coolo pushed a commit that referenced this pull request May 12, 2018
commit 1ad9148
Author:     Ettore Di Giacinto <mudler@users.noreply.github.com>
AuthorDate: Fri May 11 12:17:30 2018 +0200
Commit:     Stephan Kulow <stephan@kulow.org>
CommitDate: Fri May 11 12:17:30 2018 +0200

    Add _source field to every detail generated by parsers implementations (#1647)

    Overload constructor and do apply the custom field to all parsers using Result::OpenQA
coolo pushed a commit that referenced this pull request May 14, 2018
commit 1ad9148
Author:     Ettore Di Giacinto <mudler@users.noreply.github.com>
AuthorDate: Fri May 11 12:17:30 2018 +0200
Commit:     Stephan Kulow <stephan@kulow.org>
CommitDate: Fri May 11 12:17:30 2018 +0200

    Add _source field to every detail generated by parsers implementations (#1647)

    Overload constructor and do apply the custom field to all parsers using Result::OpenQA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants