New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add _source field to every detail generated by parsers implementations #1647
Conversation
Overload constructor and do apply the custom field to all parsers using Result::OpenQA
I haven't looked at the code yet, but I say already thanks :-) |
Why the underscore? There's nothing to hide here. |
Codecov Report
@@ Coverage Diff @@
## master #1647 +/- ##
==========================================
+ Coverage 88.92% 88.97% +0.04%
==========================================
Files 131 131
Lines 9418 9420 +2
==========================================
+ Hits 8375 8381 +6
+ Misses 1043 1039 -4
Continue to review full report at Codecov.
|
@Martchus no problem, for the _source field it's like @foursixnine says Tested on staging: http://e122.suse.de/tests/18917#step/2_tcpdmatch/6 , e.g.
|
commit 1ad9148 Author: Ettore Di Giacinto <mudler@users.noreply.github.com> AuthorDate: Fri May 11 12:17:30 2018 +0200 Commit: Stephan Kulow <stephan@kulow.org> CommitDate: Fri May 11 12:17:30 2018 +0200 Add _source field to every detail generated by parsers implementations (#1647) Overload constructor and do apply the custom field to all parsers using Result::OpenQA
commit 1ad9148 Author: Ettore Di Giacinto <mudler@users.noreply.github.com> AuthorDate: Fri May 11 12:17:30 2018 +0200 Commit: Stephan Kulow <stephan@kulow.org> CommitDate: Fri May 11 12:17:30 2018 +0200 Add _source field to every detail generated by parsers implementations (#1647) Overload constructor and do apply the custom field to all parsers using Result::OpenQA
commit 1ad9148 Author: Ettore Di Giacinto <mudler@users.noreply.github.com> AuthorDate: Fri May 11 12:17:30 2018 +0200 Commit: Stephan Kulow <stephan@kulow.org> CommitDate: Fri May 11 12:17:30 2018 +0200 Add _source field to every detail generated by parsers implementations (#1647) Overload constructor and do apply the custom field to all parsers using Result::OpenQA
Overload constructor and do apply the custom _source field to all parser formats details using Result::OpenQA
I'm testing this on staging, but should not have any regression, this should help #1639 to figure out which details were generated by the parser