-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UI controls for developer session #1691
Merged
+1,859
−378
Merged
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
fbcd903
Add UI controls for developer session
Martchus 93354f6
Expose VNC port to developer
foursixnine 68327ea
Update instructions
foursixnine 008f92f
Remove unnecesary options for livehandler service
foursixnine 8fe15fc
Update service file for livehandler service
foursixnine 82fe717
Connect via livehandler proxy to isotovideo to get updates
foursixnine 1cf00be
Fix typos
foursixnine 48e5ed1
Add status route to websocket proxy
foursixnine 1614adb
Allow developer-instructions to be modified by status updates
foursixnine 5584967
Remove deprecated ui test
foursixnine 840bc5a
Move methods to build proxy url to OpenQA::Utils
foursixnine 3a2165e
Add UI controls for developer session
Martchus 6e2bd34
Pick the right route (either developer session or status only)
Martchus 2e0ce46
Show VNC instruction only for running jobs
Martchus 9e3c5ad
Keep track of status-only and devel ws tx separately
Martchus d4f0acc
Notify clients about removed sessions as well
Martchus 343403e
Handle reconnects in the client
Martchus 17e5f68
Update module select for devel mode like modules under details
Martchus c72e632
Adapt existing developer test to UI changes
Martchus cb12a77
Hide entire developer panel when test not running
Martchus b016b47
Document variables for developer mode
Martchus 550d9b5
Check that VNC instructions are shown when test is paused
foursixnine d198635
Fix broken HTML on test details page
Martchus c3a3a00
Extend unit tests for status-only route
Martchus cdb9f7c
Fix style issues mentioned by @foursixnine in review
Martchus 9e06414
Adapt to removal of waiting state
Martchus fc67d9b
Avoid using Mojo::IOLoop->one_tick() in developer unit tests
Martchus 9796a63
Set status code when finishing ws connections
Martchus 6b20245
Start developer session via submit button
Martchus a260e9d
Fix importing determine_web_ui_web_socket_url
Martchus 5c0208b
Add tests for developer UI controls
Martchus 4675cf0
Don't quit developer session when disconnecting from os-autoinst
Martchus 4ef626a
Cancel job when quitting the developer session
Martchus d672819
Test UI controls also in developer fullstack test
Martchus fd13ce0
Improve error handling of livehandler daemon
Martchus cf792ce
Don't use Test::MockModule::redefine()
Martchus 4ed6452
Remove useless debug printing in live view handler
Martchus a488b99
Show link to ws console only in development mode
Martchus 32585a5
Prevent resetting the module to pause at on page load
Martchus 172b3c0
Replace 'opened by' with 'owned by'
Martchus 057842c
Rephrase to avoid 'developer session'
Martchus 3c1a6b2
Don't update developer mode controls until confirmed
Martchus 4af9d62
Never assume it is the own devel session when not logged in
Martchus c7d3ae7
devel mode: Handle case when module list still unknown
Martchus 7b3eae7
Fix help popover in developer panel
Martchus 513ef24
Show developer mode form only when connected via web sockets
Martchus 77e88c6
Fix bugs in form controls for devel mode
Martchus 1066d02
live view: Connect to ws server when testStatus.running is set
Martchus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not call it getabsolutewsurl? (It's just cosmetic I know ;))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it doesn't just return a value which is already stored somewhere. It actually computes the value (though this is not very expensive).