clone_job: Make _GROUP and _GROUP_ID override each other #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1716 +/- ##
==========================================
- Coverage 89.87% 88.71% -1.16%
==========================================
Files 137 137
Lines 9617 9617
==========================================
- Hits 8643 8532 -111
- Misses 974 1085 +111
Continue to review full report at Codecov.
|
foursixnine
approved these changes
Jul 6, 2018
okurz
reviewed
Jul 7, 2018
| delete $settings{NAME}; # usually autocreated | ||
| if ($depth == 0 or $options{'parental-inheritance'}) { | ||
| for my $arg (@ARGV) { | ||
| if ($arg =~ /([A-Z0-9_]+)=(.*)/) { | ||
| if (defined $2) { | ||
| $settings{$1} = $2; | ||
| if (my $override = $overrides{$1}) { | ||
| delete $settings{$override}; |
There was a problem hiding this comment.
do you have any personal indendation limit? You certainly hit mine ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://progress.opensuse.org/issues/38279
Tested locally with production data and job mentioned in the ticket.