Add UI for pausing on assert screen timeout #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Martchus
commented
Jul 19, 2018
•
Martchus
commented
- based on Improve code for devel mode, fix 'Data frame received after close' #1724
- requires Allow to pause on assert screen timeout os-autoinst#993
Martchus
force-pushed
the
pause_on_assert_screen_timeout
branch
from
75568ac
to
bafce00
Compare
Martchus
force-pushed
the
pause_on_assert_screen_timeout
branch
2 times, most recently
from
2a0ee46
to
e3210ed
Compare
|
So I now have integration/fullstack test for pausing on assert screen timeout. It works locally, however, I don't expect it to pass on Travis because it requires os-autoinst/os-autoinst#993. I'll also have to extend the tests to cover opening the needle editor when paused on |
Martchus
force-pushed
the
pause_on_assert_screen_timeout
branch
2 times, most recently
from
1790aa9
to
5a682bf
Compare
|
The fullstack developer test now also opens the needle editor when paused on This PR can still be tested on e212 btw. To check whether the tests pass on Travis, os-autoinst/os-autoinst#993 must be merged first. |
Martchus
changed the title
Martchus
force-pushed
the
pause_on_assert_screen_timeout
branch
from
d33914c
to
0e03d86
Compare
|
it's merged now - please rebase? |
Martchus
force-pushed
the
pause_on_assert_screen_timeout
branch
from
0e03d86
to
1200edf
Compare
Codecov Report
@@ Coverage Diff @@
## master #1727 +/- ##
==========================================
+ Coverage 88.71% 90.03% +1.32%
==========================================
Files 139 139
Lines 9738 9747 +9
==========================================
+ Hits 8639 8776 +137
+ Misses 1099 971 -128
Continue to review full report at Codecov.
|
|
Rebased and since os-autoinst/os-autoinst#993 has been merged tests pass. |
|
I think it can be merged as soon as the overall fallout is cleaned. The successive PR is deployed on e212. |
|
@Martchus please rebase :) |
Better than suggesting to restart the job because the devel mode allows to reload needles on resume.
* Upload results in the middle of a test module when paused so the needle editor can be used at this point * Take care that not multiple test modules are marked as running at the same time
Adjust wait_for_developer_console_contains_log_message so only log messages since the last successful match are considered. This should prevent problems when extending 33-developer_mode.t to pause/resume multiple times.
Requires changes of os-autoinst/os-autoinst#993
So when opening the needle editor from the developer mode on pause the user at least knows why it is not working/available.
The previous commit contains already tests for the error handling, so let's add a test for the positive case as well.
Reload page after switching to 2nd tab to block until it has finished
loading.
Note that neither opening the 2nd tab (via window.open()) nor switching
to it seems to block until the page has finished loading.
This should prevent:
Error while executing command: no such element: Unable to locate element:
{"method":"css selector","selector":"#log"}
Test::More::subtest("connect with 2 clients at the same time (use case:
developer "..., CODE(0x560552f407f0)) called at t/33-developer_mode.t
line 392
Martchus
force-pushed
the
pause_on_assert_screen_timeout
branch
from
1200edf
to
882a886
Compare
|
I just love how flaky the fullstack test is now :) |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.