Fixed blocked_by calculation not to create loops #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is hotpatched on osd - and it obviously needs investment in tests |
|
On the bike I had the thought, that even chained_parents shouldn't be necessary - as we look at $self too. But please come up with test scenarios for blocked_by - I'll be on vacation |
blocked_by means: either one job in the parallel cluster or a parent of a chained parent is not final. So looking at chained_children of the cluster gives us possibly a cycle As such don't look at the full cluster's chained deps, but only of those pointing up
coolo
force-pushed
the
fix_blocked_by
branch
from
da8bc28
to
4857431
Compare
Codecov Report
@@ Coverage Diff @@
## revert_to_new_scheduler #1743 +/- ##
===========================================================
- Coverage 90.22% 90.21% -0.01%
===========================================================
Files 139 139
Lines 9704 9711 +7
===========================================================
+ Hits 8755 8761 +6
- Misses 949 950 +1
Continue to review full report at Codecov.
|
While doing so I discoverated that duplicate does not calculate blocked_by
This was messed up in the revert revert commit
|
the revert was half broken when it comes to the orange - fortunately @mitiao's test case triggered once I fixed the blocked_by for duplication |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked_by means: either one job in the parallel cluster or
a parent of a chained parent is not final. So looking at
chained_children of the cluster gives us possibly a cycle
As such don't look at the full cluster's chained deps, but
only of those pointing up