Test using phantomjs #177
Merged
Test using phantomjs #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
selenium doesn't like devel::cover |
coolo
force-pushed
the
test_phantomjs
branch
6 times, most recently
from
c3bb145
to
bfcc595
Compare
|
AWESOME! |
|
note that the coverage actually dropps below 70% with this as I exclude t/* now - which is stupid IMO to count as covered code |
|
I have always been sure that our coverage stats are a plain lie, although I have never take the time to verify the reason. |
.../_common/deploy/_any/21-seeds.pl 100.0 n/a n/a 100.0 0.1 100.0 lib/DBIx/Class/Timestamps.pm 100.0 n/a n/a 100.0 5.8 100.0 lib/OpenQA.pm 91.0 50.0 45.4 85.0 0.8 86.0 lib/OpenQA/Auth/Fake.pm 100.0 50.0 n/a 100.0 1.5 95.8 lib/OpenQA/Auth/OpenID.pm 13.4 0.0 0.0 25.0 1.5 10.7 lib/OpenQA/Auth/iChain.pm 18.7 0.0 n/a 25.0 1.4 18.1 lib/OpenQA/Client.pm 100.0 81.2 50.0 100.0 1.0 90.3 lib/OpenQA/Controller/API/V1.pm 97.0 77.7 66.6 100.0 2.5 88.7 ...penQA/Controller/API/V1/Asset.pm 97.9 83.3 n/a 100.0 2.9 96.8 ...nQA/Controller/API/V1/Command.pm 69.2 n/a n/a 75.0 2.8 70.5 lib/OpenQA/Controller/API/V1/Iso.pm 90.8 52.6 36.3 90.9 2.7 77.7 lib/OpenQA/Controller/API/V1/Job.pm 42.1 42.8 0.0 47.3 2.7 42.3 ...Controller/API/V1/JobTemplate.pm 74.4 61.3 50.0 66.6 2.6 66.8 ...penQA/Controller/API/V1/Table.pm 89.6 70.0 100.0 100.0 2.5 86.5 ...enQA/Controller/API/V1/Worker.pm 97.0 50.0 n/a 100.0 2.5 95.4 ...OpenQA/Controller/Admin/Asset.pm 42.8 n/a n/a 50.0 2.4 44.4 .../Controller/Admin/JobTemplate.pm 15.3 0.0 0.0 50.0 2.3 14.5 ...enQA/Controller/Admin/Machine.pm 100.0 n/a n/a 100.0 2.3 100.0 ...enQA/Controller/Admin/Product.pm 25.0 n/a n/a 50.0 2.2 28.5 ...QA/Controller/Admin/TestSuite.pm 25.0 n/a n/a 50.0 2.2 28.5 lib/OpenQA/Controller/Admin/User.pm 95.4 80.0 n/a 100.0 2.2 91.4 ...enQA/Controller/Admin/Workers.pm 40.9 n/a n/a 60.0 2.1 44.4 lib/OpenQA/Controller/ApiKey.pm 100.0 100.0 100.0 100.0 1.4 100.0 lib/OpenQA/Controller/File.pm 77.4 52.7 37.5 87.5 1.3 70.5 lib/OpenQA/Controller/Running.pm 16.5 0.0 0.0 36.8 1.2 14.0 lib/OpenQA/Controller/Session.pm 62.8 46.6 66.6 76.9 1.2 60.6 lib/OpenQA/Controller/Step.pm 58.0 45.7 26.5 82.6 1.2 53.4 lib/OpenQA/Controller/Test.pm 86.8 75.0 44.8 90.0 1.1 79.9 lib/OpenQA/Controller/Worker.pm 27.2 0.0 n/a 57.1 0.9 27.1 lib/OpenQA/Plugin/CSRF.pm 100.0 66.6 33.3 100.0 0.9 91.6 lib/OpenQA/Plugin/HashedParams.pm 84.2 41.6 n/a 100.0 0.8 75.4 lib/OpenQA/Plugin/Helpers.pm 94.1 72.7 66.6 100.0 1.0 85.0 lib/OpenQA/Plugin/REST.pm 97.2 75.0 33.3 100.0 1.2 91.2 lib/OpenQA/Scheduler.pm 84.7 70.1 58.3 87.5 1.4 80.3 lib/OpenQA/Schema/Schema.pm 90.0 n/a n/a 85.7 0.1 88.8 lib/OpenQA/Utils.pm 57.1 40.4 80.0 71.4 4.9 55.7 lib/OpenQA/Variables.pm 52.8 25.0 14.2 88.8 0.2 48.2 lib/OpenQA/WebSockets.pm 72.8 50.0 50.0 76.9 0.1 67.3 lib/db_helpers.pm 100.0 50.0 80.0 100.0 30.2 88.6 lib/db_profiler.pm 29.0 n/a n/a 37.5 0.0 30.7 Total 72.1 55.4 42.6 78.8 100.0 67.5 |
Merged
This is much easier for new contributors
coolo
force-pushed
the
test_phantomjs
branch
from
bfcc595
to
48550b4
Compare
|
rebased on #180 |
| @@ -39,7 +39,7 @@ sub _read_config { | |||
| hsts => 365, | |||
| }, | |||
| auth => { | |||
| method => 'OpenID', | |||
| method => 'Fake', | |||
There was a problem hiding this comment.
Just to document offline discussion: We need to change this at least in the package. The code (not just a config file template) must default to openid there.
|
now that's depressing: a weekend of work and 59.23 -> 60.19 :) |
as long as it doesn't build on power, it's optional
coolo
force-pushed
the
test_phantomjs
branch
from
e601551
to
8efe3d4
Compare
|
I'll prepare the packaging |
|
Note that currently the auth_method name must be exactly the same as the pm file name (sans pm suffix). So in case of iChain it must be with lower i. Sorry, I didn't notice that before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.