Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'last_match' param of AJAX route for needle table #1802

Merged
merged 1 commit into from Sep 23, 2018

Conversation

Martchus
Copy link
Contributor

@coolo
Copy link
Contributor

coolo commented Sep 21, 2018

this just demonstrates that noone but me checks old needles and deletes them - and that we should automate that :(

@codecov
Copy link

codecov bot commented Sep 21, 2018

Codecov Report

Merging #1802 into master will increase coverage by 16.91%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1802       +/-   ##
===========================================
+ Coverage   73.31%   90.23%   +16.91%     
===========================================
  Files         123      139       +16     
  Lines        9197     9871      +674     
===========================================
+ Hits         6743     8907     +2164     
+ Misses       2454      964     -1490
Impacted Files Coverage Δ
lib/OpenQA/WebAPI/Controller/Admin/Needle.pm 81.35% <0%> (ø) ⬆️
lib/OpenQA.pm 69.23% <0%> (ø)
lib/OpenQA/WebAPI/Controller/API/V1/Command.pm 30.76% <0%> (ø)
lib/OpenQA/Script.pm 90% <0%> (ø)
lib/OpenQA/Parser/Format/Base.pm 100% <0%> (ø)
lib/OpenQA/WebAPI/Plugin/Fedmsg.pm 96.87% <0%> (ø)
lib/OpenQA/WebAPI/Controller/API/V1/Locks.pm 96.77% <0%> (ø)
lib/OpenQA/Parser/Format/LTP.pm 100% <0%> (ø)
lib/OpenQA/WebAPI/Controller/API/V1/Mm.pm 58.33% <0%> (ø)
lib/OpenQA/Parser/Format/TAP.pm 100% <0%> (ø)
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87a1a4d...6930dc5. Read the comment docs.

@Martchus
Copy link
Contributor Author

Martchus commented Sep 21, 2018

The failing worker test is unrelated. I can reproduce the failure locally - but also on master.

And yes, we should automate this. Nevertheless, fixing the table makes sense.

@coolo coolo merged commit 7505592 into os-autoinst:master Sep 23, 2018
@Martchus Martchus deleted the fix_admin_needle_ajax branch September 23, 2018 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants