Add always_rolllback doc and flag icon #1812

rwx788 · 2018-09-28T15:06:26Z

Please, merge only after os-autoinst change.

codecov · 2018-09-28T15:28:58Z

Codecov Report

Merging #1812 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1812      +/-   ##
==========================================
- Coverage    90.3%   90.28%   -0.02%     
==========================================
  Files         140      140              
  Lines       10065    10065              
==========================================
- Hits         9089     9087       -2     
- Misses        976      978       +2

Impacted Files	Coverage Δ
lib/OpenQA/Schema/Result/JobModules.pm	`87.31% <ø> (ø)`	⬆️
lib/OpenQA/Schema.pm	`100% <ø> (ø)`	⬆️
lib/OpenQA/Utils.pm	`91.85% <ø> (ø)`	⬆️
lib/OpenQA/WebAPI/Controller/API/V1/Job.pm	`88.25% <100%> (ø)`	⬆️
lib/OpenQA/Schema/Result/Jobs.pm	`92.43% <100%> (ø)`	⬆️
lib/OpenQA/Worker/Engines/isotovideo.pm	`94.37% <0%> (-1.25%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aaf4f2...dd4ac14. Read the comment docs.

coolo · 2018-09-28T15:44:22Z

docs/WritingTests.asciidoc

@@ -79,6 +80,7 @@ sub test_flags {
    # 'ignore_failure' - if this module fails, it will not affect the overall result at all
    # 'milestone'      - after this test succeeds, update 'lastgood'
    # 'norollback'     - don't roll back to 'lastgood' snapshot if this fails
+    # 'force_reset'    - roll back to 'lastgood' snapshot even if test was successful (supported on QEMU backend only)


I wonder if we shouldn't name 'QEMU backend' the default - sounds less scary :)

Right, we don't mention it above as well. I will replace with something like "if supported by backend"

It didn't bother me on the first review - but I just had the thought that force_reset sounds a lot like a boot of the SUT. In the light of 'norollback', how about always_rollback (and possibly renaming norollback to no_rollback).

I also thought about different name, but grabbed one from the progress ticket. As we use norollback just in a single place, it's easy change. So +1 here.

okurz · 2018-09-29T10:22:47Z

docs/WritingTests.asciidoc

@@ -40,8 +40,9 @@ openQA tests need to implement at least the *run* subroutine to
 contain the actual test code and the test needs to be loaded in the distribution's
 main.pm.

-The *test_flags* subroutine specifies what happens when the test
-fails.
+The *test_flags* subroutine specifies what should happen when test execution is finished.


In before it stated "if test fails" which would refer to each failure within a job. Now it states "when test execution is finished" which I consider ambiguous. How about "when the execution of the current test module finishes depending on the result …"

rwx788 · 2018-10-01T16:29:04Z

Test for the change is in progress. Looking for a suiting place for it.

coolo · 2018-10-16T19:01:09Z

dbicdh/PostgreSQL/upgrade/69-70/001-auto.sql


+;
+ALTER TABLE job_modules ADD COLUMN always_rollback integer DEFAULT 0 NOT NULL;


this doesn't work - you need a new schema version

Unfortunately, I was able only to find the documentation to introduce changes to the DB this way. Do you think @Martchus can give me a hand here?

I can, but I usually just go through these steps myself: https://github.com/os-autoinst/openQA/blob/master/docs/Contributing.asciidoc#managing-the-database

You forgot step 1. here (updating the schema version number) and instead overwrote the previous migration files.

Ah, I see. Will fix that. Thanks a lot!

coolo · 2018-10-17T13:13:25Z

I'm still missing a commit in Schema.pm

rwx788 · 2018-10-17T14:05:30Z

@coolo sorry, messed up this PR with reverts, so now it can be looked at.

Martchus

Looks good now.

It conflicts with #1835 so the PR which is merged last needs to rebase.

coolo · 2018-10-17T15:01:53Z

@Martchus your call then in which order. 1835 is more urgent, but I expect you to be more fluent in rebaing

rwx788 · 2018-10-17T15:04:40Z

@coolo as this PR is not urgent, I can also take my time for rebasing, so no issue with that.

Martchus · 2018-10-17T15:28:33Z

Rebasing should be quite easy in this case so it doesn't really matter - I've just noted it.

See [poo#30775](https://progress.opensuse.org/issues/30775).

rwx788 · 2018-10-17T16:07:54Z

Conflict resolved. Should be fine now.

rwx788 mentioned this pull request Sep 28, 2018

Add test flag to revert to last good when test module didn't fail os-autoinst/os-autoinst#1034

Merged

coolo reviewed Sep 28, 2018

View reviewed changes

okurz reviewed Sep 29, 2018

View reviewed changes

okurz mentioned this pull request Sep 29, 2018

Delete outdated references to flags os-autoinst/os-autoinst-distri-example#3

Merged

rwx788 changed the title ~~Add force_reset flag description~~ [WIP] Add force_reset flag description Oct 1, 2018

rwx788 force-pushed the automated_comment branch from 11aff4a to 35b151e Compare October 1, 2018 09:13

rwx788 changed the title ~~[WIP] Add force_reset flag description~~ [WIP] Add always_rolllback doc and flag icon Oct 1, 2018

rwx788 force-pushed the automated_comment branch from 3ec364b to c690d54 Compare October 1, 2018 16:28

rwx788 force-pushed the automated_comment branch 2 times, most recently from 4f4631e to 279ffb1 Compare October 2, 2018 09:52

okurz mentioned this pull request Oct 2, 2018

Add test for HANA SAP Installation Wizard os-autoinst/os-autoinst-distri-opensuse#5862

Merged

rwx788 force-pushed the automated_comment branch from 279ffb1 to 8e13bc1 Compare October 2, 2018 15:50

rwx788 changed the title ~~[WIP] Add always_rolllback doc and flag icon~~ Add always_rolllback doc and flag icon Oct 2, 2018

rwx788 force-pushed the automated_comment branch 7 times, most recently from af6dc3d to 4969be6 Compare October 16, 2018 10:39

coolo reviewed Oct 16, 2018

View reviewed changes

rwx788 force-pushed the automated_comment branch 5 times, most recently from 2465bab to c2cf168 Compare October 17, 2018 13:09

rwx788 force-pushed the automated_comment branch from 6bd2c94 to 499200e Compare October 17, 2018 13:30

Martchus approved these changes Oct 17, 2018

View reviewed changes

Rodion Iafarov added 4 commits October 17, 2018 18:05

Add always_rollback flag description

62df48c

See [poo#30775](https://progress.opensuse.org/issues/30775).

Add special icon for the always rollback flag

09e5685

Add tests for test module flags

836a0a8

Create new db schema version

dd4ac14

rwx788 force-pushed the automated_comment branch from 499200e to dd4ac14 Compare October 17, 2018 16:07

coolo merged commit 587a775 into os-autoinst:master Oct 23, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add always_rolllback doc and flag icon #1812

Add always_rolllback doc and flag icon #1812

rwx788 commented Sep 28, 2018 •

edited

codecov bot commented Sep 28, 2018 •

edited

coolo Sep 28, 2018

rwx788 Sep 28, 2018

coolo Sep 29, 2018

rwx788 Oct 1, 2018

okurz Sep 29, 2018

rwx788 commented Oct 1, 2018

coolo Oct 16, 2018

rwx788 Oct 17, 2018

Martchus Oct 17, 2018

rwx788 Oct 17, 2018

coolo commented Oct 17, 2018

rwx788 commented Oct 17, 2018

Martchus left a comment

coolo commented Oct 17, 2018

rwx788 commented Oct 17, 2018

Martchus commented Oct 17, 2018

rwx788 commented Oct 17, 2018


		;
		ALTER TABLE job_modules ADD COLUMN always_rollback integer DEFAULT 0 NOT NULL;

Add always_rolllback doc and flag icon #1812

Add always_rolllback doc and flag icon #1812

Conversation

rwx788 commented Sep 28, 2018 • edited

codecov bot commented Sep 28, 2018 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rwx788 commented Oct 1, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coolo commented Oct 17, 2018

rwx788 commented Oct 17, 2018

Martchus left a comment

Choose a reason for hiding this comment

coolo commented Oct 17, 2018

rwx788 commented Oct 17, 2018

Martchus commented Oct 17, 2018

rwx788 commented Oct 17, 2018

rwx788 commented Sep 28, 2018 •

edited

codecov bot commented Sep 28, 2018 •

edited