search()->update() can wipe the entire table

[coolo]

So we better require a fixed DBIx::Class (unfortunately 13.2 is affected by this)

Also don't put 2 now() in one update call to avoid the harmless but still ugly
warning about possibly corrupt data (I don't see any value in setting the started == finished)

also fix one -in call

[lnussel]

AFAIR scheduled jobs are meant to be set to cancelled rather than done+incomplete. the latter is used for jobs that were running already. And in case of cancelled neither t_started nor t_finished make sense to be set.

[coolo]

it's actually very confusing in the webui to see jobs as incomplete because their parent failed

[coolo]

btw: I already fixed the package to require the fixed DBIx::Class, so this PR is mainly for cleanup

[nadvornik]

Problem with CANCELLED is that it can be changed back to SCHEDULED. For a job with dependencies it could be problematic. Currently, the job is DONE, job_restart duplicates it and the CHAINED dependency to the parent is dropped during duplication.

So we can either add a new result to indicate that the job failed because of dependencies (maybe use existing SKIPPED?) or handle restarting of CANCELLED job the same as DONE job.

[coolo]

SKIPPED sounds good to me

[lnussel]

Vladimir Nadvornik schrieb:

Problem with CANCELLED is that it can be changed back to SCHEDULED.
For a job with dependencies it could be problematic. Currently, the
job is DONE, job_restart duplicates it and the CHAINED dependency to
the parent is dropped during duplication.

So the code that restarts resp uncancels jobs needs to be made aware
of chains I guess :-)

So we can either add a new result to indicate that the job failed
because of dependencies (maybe use existing SKIPPED?) or handle
restarting of CANCELLED job the same as DONE job.

We had a similar discussion for jobs that were cancelled because a
new iso was uploaded. A new state obsoleted was introduced for
them. Maybe a new state would be the solution here too indeed.

[coolo]

SKIPPED is a result, not a state.

[nadvornik]

I have put my proposal here:
https://progress.opensuse.org/issues/6148