Update results for the current module when paused on assert_screen timeout #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Martchus
commented
Oct 19, 2018
Martchus
commented
- See https://progress.opensuse.org/issues/42407
- Built on top of Lazy-initialize devel mode when switching to live view tab #1838
- Related changes in os-autoinst (must not necessarily merged at the same time): Upload full mismatch when paused on assert_screen timeout os-autoinst#1044
Attempt to load new details only when the upload has been completed by the worker.
The tests page is now able to update the results for the currently running module. Hence it must be prevented that the preview is destroyed when opened for a detail of the current module at the time of the update.
Codecov Report
@@ Coverage Diff @@
## master #1839 +/- ##
==========================================
+ Coverage 89.95% 90.31% +0.35%
==========================================
Files 140 140
Lines 10075 10075
==========================================
+ Hits 9063 9099 +36
+ Misses 1012 976 -36
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.