Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network dependency for cache service #1896

Merged
merged 1 commit into from Nov 28, 2018

Conversation

nicksinger
Copy link
Member

Maybe this makes @coolo more happy :)

@okurz
Copy link
Member

okurz commented Nov 28, 2018

but do we know we actually need this?

@nicksinger
Copy link
Member Author

All I really know is: "network.target has very little meaning during start-up. It only indicates that the network management stack is up after it has been reached." which is what @coolo send me after proposing network.target as dep.

@okurz
Copy link
Member

okurz commented Nov 28, 2018

yes, this is what we learned in #1884 (comment) and this is why I stated exactly that in my commit message in #1878 hence my question: "Do we know we actually need this?"

@Martchus
Copy link
Contributor

Martchus commented Nov 28, 2018

And that comment also states "The problem should be fixed in the code itself" which is what the systemd documentation suggests as well.

@kraih Maybe there's a switch in Mojolicous so it behaves out of the box like https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget describes "well-written" software?

@foursixnine foursixnine merged commit 68cd3c3 into os-autoinst:master Nov 28, 2018
@okurz
Copy link
Member

okurz commented Nov 28, 2018

@foursixnine I wonder are you just blindly hitting merge buttons in error or do you follow the discussion here? Probably it's your secret #qa-tools room discussion where I was pseudo-banned from ;)

coolo pushed a commit that referenced this pull request Nov 28, 2018
commit 68cd3c3
Merge: 10d9344 a87491f
Author:     Santiago Zarate <santiago@zarate.co>
AuthorDate: Wed Nov 28 15:11:33 2018 +0100
Commit:     GitHub <noreply@github.com>
CommitDate: Wed Nov 28 15:11:33 2018 +0100

    Merge pull request #1896 from nicksinger/fix_networkdeps

    Fix network dependency for cache service
@foursixnine
Copy link
Member

@okurz Not really :) I missed the network-online target in the previous PR, @nicksinger was kind enough to provide the new pr :), I hit merge after double checking, that's it.

@okurz
Copy link
Member

okurz commented Nov 28, 2018

@Martchus I agree with you, can you please make sure that this is being followed on, e.g. with a ticket or something? Depending on if you and @kraih maybe have discussed further already

@kraih
Copy link
Member

kraih commented Nov 28, 2018

I don't think there is anything Mojolicious could do differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants