Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error/inconsistency in asset cleanup #1919

Merged
merged 2 commits into from
Dec 13, 2018

Conversation

Martchus
Copy link
Contributor

@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #1919 into master will increase coverage by 6.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1919      +/-   ##
==========================================
+ Coverage   84.41%   90.63%   +6.21%     
==========================================
  Files         148      148              
  Lines       10310    10311       +1     
==========================================
+ Hits         8703     9345     +642     
+ Misses       1607      966     -641
Impacted Files Coverage Δ
lib/OpenQA/Schema/ResultSet/Assets.pm 98.5% <100%> (+0.01%) ⬆️
lib/OpenQA.pm 69.23% <0%> (-2.57%) ⬇️
lib/OpenQA/Worker/Commands.pm 82.14% <0%> (-2.39%) ⬇️
lib/OpenQA/WebSockets/Server.pm 91.78% <0%> (-0.46%) ⬇️
lib/OpenQA/Worker/Engines/isotovideo.pm 96.64% <0%> (+1.11%) ⬆️
lib/OpenQA/WebAPI/Controller/API/V1/Job.pm 88% <0%> (+1.45%) ⬆️
lib/OpenQA/WebAPI/Controller/Running.pm 75.2% <0%> (+1.6%) ⬆️
lib/OpenQA/Schema/Result/Jobs.pm 92.48% <0%> (+1.65%) ⬆️
lib/OpenQA/WebAPI/Controller/Main.pm 92.45% <0%> (+1.88%) ⬆️
lib/OpenQA/WebAPI/Plugin/Gru.pm 90.29% <0%> (+1.94%) ⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19a4cf6...24d8ec5. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #1919 into master will increase coverage by 6.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1919      +/-   ##
==========================================
+ Coverage   84.41%   90.63%   +6.21%     
==========================================
  Files         148      148              
  Lines       10310    10311       +1     
==========================================
+ Hits         8703     9345     +642     
+ Misses       1607      966     -641
Impacted Files Coverage Δ
lib/OpenQA/Schema/ResultSet/Assets.pm 98.5% <100%> (+0.01%) ⬆️
lib/OpenQA.pm 69.23% <0%> (-2.57%) ⬇️
lib/OpenQA/Worker/Commands.pm 82.14% <0%> (-2.39%) ⬇️
lib/OpenQA/WebSockets/Server.pm 91.78% <0%> (-0.46%) ⬇️
lib/OpenQA/Worker/Engines/isotovideo.pm 96.64% <0%> (+1.11%) ⬆️
lib/OpenQA/WebAPI/Controller/API/V1/Job.pm 88% <0%> (+1.45%) ⬆️
lib/OpenQA/WebAPI/Controller/Running.pm 75.2% <0%> (+1.6%) ⬆️
lib/OpenQA/Schema/Result/Jobs.pm 92.48% <0%> (+1.65%) ⬆️
lib/OpenQA/WebAPI/Controller/Main.pm 92.45% <0%> (+1.88%) ⬆️
lib/OpenQA/WebAPI/Plugin/Gru.pm 90.29% <0%> (+1.94%) ⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19a4cf6...24d8ec5. Read the comment docs.

Copy link
Contributor

@coolo coolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks quite specific :)

@Martchus Martchus merged commit 47bc70f into os-autoinst:master Dec 13, 2018
@Martchus Martchus deleted the limit_assets branch December 13, 2018 09:05
coolo pushed a commit that referenced this pull request Dec 13, 2018
commit 47bc70f
Merge: 19a4cf6 24d8ec5
Author:     Martchus <martchus@gmx.net>
AuthorDate: Thu Dec 13 10:05:12 2018 +0100
Commit:     GitHub <noreply@github.com>
CommitDate: Thu Dec 13 10:05:12 2018 +0100

    Merge pull request #1919 from Martchus/limit_assets

    Fix error/inconsistency in asset cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants