Handle undefined $text in find_bugref and find_bugrefs
#1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have quite a few warnings like this in Fedora's openQA logs: Jan 09 17:55:55 openqa-stg01.qa.fedoraproject.org openqa[27943]: Use of uninitialized value $text in pattern match (m//) at /usr/share/openqa/script/../lib/OpenQA/Utils.pm line 629 It seems like something is calling `find_bugref` with `$text` undefined. Rather than figuring out exactly what's doing that, it seems easier to just tweak `find_bugref` to handle being called with the text undefined. And we may as well do the same for `find_bugrefs` since it's, like, right there! See https://progress.opensuse.org/issues/39923 Signed-off-by: Adam Williamson <awilliam@redhat.com>
Martchus
approved these changes
Jan 10, 2019
|
Btw, the failing test is unrelated. |
|
LGTM retriggered the failed job, something about "# Subtest: test cancelled by quitting the session Should we use travis_retry? |
Codecov Report
@@ Coverage Diff @@
## master #1947 +/- ##
==========================================
- Coverage 89.09% 88.82% -0.28%
==========================================
Files 154 154
Lines 10373 10421 +48
==========================================
+ Hits 9242 9256 +14
- Misses 1131 1165 +34
Continue to review full report at Codecov.
|
coolo
pushed a commit
that referenced
this pull request
Jan 14, 2019
commit 5672fc3 Merge: 680a199 95507be Author: Martchus <martchus@gmx.net> AuthorDate: Mon Jan 14 11:27:03 2019 +0100 Commit: GitHub <noreply@github.com> CommitDate: Mon Jan 14 11:27:03 2019 +0100 Merge pull request #1947 from AdamWill/bugref-undefined Handle undefined `$text` in `find_bugref` and `find_bugrefs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have quite a few warnings like this in Fedora's openQA logs:
Jan 09 17:55:55 openqa-stg01.qa.fedoraproject.org openqa[27943]: Use of uninitialized value $text in pattern match (m//) at /usr/share/openqa/script/../lib/OpenQA/Utils.pm line 629
It seems like something is calling
find_bugrefwith$textundefined. Rather than figuring out exactly what's doing that,
it seems easier to just tweak
find_bugrefto handle beingcalled with the text undefined. And we may as well do the same
for
find_bugrefssince it's, like, right there!See https://progress.opensuse.org/issues/39923
Signed-off-by: Adam Williamson awilliam@redhat.com