Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modules filter wrong results while using comma #1993

Merged

Conversation

OleksandrOrlov
Copy link

Filter returned results only when one module was specified in the Module
filter field on Test Result Overview page. It returned no results while
using comma-separated module names.

The commit fixes the issue and allows to filter job groups by several
module names separated by comma (e.g. module1,module2).

Filter returned results only when one module was specified in the Module
filter field on Test Result Overview page. It returned no results while
using comma-separated module names.

The commit fixes the issue and allows to filter job groups by several
module names separated by comma (e.g. module1,module2).
@codecov
Copy link

codecov bot commented Feb 10, 2019

Codecov Report

Merging #1993 into master will decrease coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1993      +/-   ##
==========================================
- Coverage   89.14%   88.99%   -0.16%     
==========================================
  Files         154      154              
  Lines       10438    10438              
==========================================
- Hits         9305     9289      -16     
- Misses       1133     1149      +16
Impacted Files Coverage Δ
lib/OpenQA/Utils.pm 94.57% <100%> (-0.18%) ⬇️
lib/OpenQA/Scheduler/Scheduler.pm 88.47% <0%> (-2.31%) ⬇️
lib/OpenQA/Worker/Common.pm 82.04% <0%> (-2.12%) ⬇️
lib/OpenQA/WebSockets/Server.pm 90.41% <0%> (-1.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aab5333...bcf7b17. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 10, 2019

Codecov Report

Merging #1993 into master will decrease coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1993      +/-   ##
==========================================
- Coverage   89.14%   88.99%   -0.16%     
==========================================
  Files         154      154              
  Lines       10438    10438              
==========================================
- Hits         9305     9289      -16     
- Misses       1133     1149      +16
Impacted Files Coverage Δ
lib/OpenQA/Utils.pm 94.57% <100%> (-0.18%) ⬇️
lib/OpenQA/Scheduler/Scheduler.pm 88.47% <0%> (-2.31%) ⬇️
lib/OpenQA/Worker/Common.pm 82.04% <0%> (-2.12%) ⬇️
lib/OpenQA/WebSockets/Server.pm 90.41% <0%> (-1.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aab5333...bcf7b17. Read the comment docs.

@okurz
Copy link
Member

okurz commented Feb 10, 2019

Seems like https://travis-ci.org/os-autoinst/openQA/jobs/490617158 failed because the docker image failed to be pulled. I retriggered the travis CI job https://travis-ci.org/os-autoinst/openQA/jobs/490617158 which passed now.

@okurz okurz merged commit aaa768d into os-autoinst:master Feb 10, 2019
coolo pushed a commit that referenced this pull request Feb 10, 2019
commit aaa768d
Merge: aab5333 bcf7b17
Author:     Oliver Kurz <okurz@suse.de>
AuthorDate: Sun Feb 10 12:06:51 2019 +0100
Commit:     GitHub <noreply@github.com>
CommitDate: Sun Feb 10 12:06:51 2019 +0100

    Merge pull request #1993 from OleksandrOrlov/fix_module_filter_with_comma

    Fix modules filter wrong results while using comma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants