Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set user correctly in OpenQA::Git instantiation #2069

Merged
merged 3 commits into from May 15, 2019
Merged

Set user correctly in OpenQA::Git instantiation #2069

merged 3 commits into from May 15, 2019

Conversation

Martchus
Copy link
Contributor

See failed Minion jobs on OSD.

@codecov
Copy link

codecov bot commented May 13, 2019 •
edited

Codecov Report

Merging #2069 into master will increase coverage by 0.54%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2069      +/-   ##
==========================================
+ Coverage   88.37%   88.91%   +0.54%     
==========================================
  Files         169      169              
  Lines       10840    10847       +7     
==========================================
+ Hits         9580     9645      +65     
+ Misses       1260     1202      -58
Impacted Files Coverage Δ
lib/OpenQA/Schema/Result/Needles.pm 75.58% <0%> (ø) ⬆️
lib/OpenQA/Git.pm 95.91% <100%> (+0.68%) ⬆️
lib/OpenQA/Task/Needle/Save.pm 71.91% <100%> (+62.92%) ⬆️
lib/OpenQA/Schema/ResultSet/Needles.pm 100% <0%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9935286...e36a8a6. Read the comment docs.

@Martchus Martchus requested a review from kalikiana May 13, 2019 13:46
@Martchus Martchus force-pushed the fix_git branch 2 times, most recently from e03e0c3 to 4f22d3e Compare May 13, 2019 15:42
kalikiana
kalikiana reviewed May 14, 2019
View reviewed changes
lib/OpenQA/Git.pm Outdated Show resolved Hide resolved
@Martchus Martchus merged commit 3815e41 into os-autoinst:master May 15, 2019
@Martchus Martchus deleted the fix_git branch May 15, 2019 13:57
coolo pushed a commit that referenced this pull request May 15, 2019
Update documentation to commit 3815e41
96654aa 
commit 3815e41
Merge: d98426e e36a8a6
Author:     Martchus <martchus@gmx.net>
AuthorDate: Wed May 15 15:57:26 2019 +0200
Commit:     GitHub <noreply@github.com>
CommitDate: Wed May 15 15:57:26 2019 +0200

    Merge pull request #2069 from Martchus/fix_git

    Set user correctly in OpenQA::Git instantiation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalikiana kalikiana kalikiana left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Martchus @kalikiana