[issue 5428] No longer let the worker store things in share/testresults #212
Conversation
|
that's rather sad, but more worker code == less coverage ;( |
| my $workerurl = $worker->{properties}->{WORKER_IP} . ':' . $workerport; | ||
| $self->stash('worker', $job->worker); | ||
| my $workerport = $job->worker->get_property('WORKER_PORT'); | ||
| my $workerurl = $job->worker->get_property('WORKER_IP') . ':' . $workerport; |
There was a problem hiding this comment.
I think WORKER_PORT and IP aren't needed for anything anymore.
There was a problem hiding this comment.
depends on your definition of needing:
./templates/test/running.html.ep: Worker: <%= $worker->{properties}->{WORKER_IP} %>:<%= $worker->{properties}->{WORKER_PORT} %>
|
Heh, I didn't notice your 'not yet finished' note, now those TODOs makes sense. :) |
|
The ultimative goal is to have openQA act on DB and not on files - so the worker reads the files and uploads them as needed. There is no need for us to store the things as os-autoinst spits them out. What matters is that we can dig them quickly in the webui. See also https://progress.opensuse.org/issues/6496 for an idea how to make an even bigger mess with the files :) |
coolo
force-pushed
the
issue_5428
branch
3 times, most recently
from
afdeca3
to
237d7bd
Compare
|
I rebased the branch and removed all debugging aids as it works pretty fine now. What's missing:
|
I will need a 2nd route for that - pngs as base64 JSON are already challenging :) |
and changed script/tidy not to touch files that are fine - emacs doesn't like that at all
|
wrote a migration now and rebased one more time :) |
|
I just counted: I added netto 0 TODOs as I removed 3 :) left TODO:
|
- add jobs::backend which stores the backend name extracted from the infos - add jobs::result_dir which stores the subdirectory name (so we can change the NAME format later)
|
I'm done with my TODO |
|
I would like to merge this tomorrow morning and rebase Ludwig' changes together with him - so last chance for public humilation :) |
|
Looks fine to me, I skipped DB schema update though. |
[issue 5428] No longer let the worker store things in share/testresults
The worker uploads everything through HTTP - not yet finished though and it goes together with the os-autoinst pull request.
Just for review/discussion for now