Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make target "test-with-database" for easier test database setup #2131

Merged
merged 1 commit into from
Jul 5, 2019

Conversation

okurz
Copy link
Member

@okurz okurz commented Jun 23, 2019

@okurz okurz changed the title Add make target "test-with-database" for easier test database setup [WIP] Add make target "test-with-database" for easier test database setup Jun 23, 2019
@okurz

This comment has been minimized.

@codecov

This comment has been minimized.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 23, 2019

Codecov Report

Merging #2131 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2131      +/-   ##
=========================================
- Coverage    89.8%   89.7%   -0.11%     
=========================================
  Files         170     170              
  Lines       10626   10626              
=========================================
- Hits         9543    9532      -11     
- Misses       1083    1094      +11
Impacted Files Coverage Δ
lib/OpenQA/WebSockets.pm 86.95% <0%> (-7.25%) ⬇️
lib/OpenQA/Scheduler/Model/Jobs.pm 86.11% <0%> (-2.78%) ⬇️
lib/OpenQA/Utils.pm 95.81% <0%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9b694d...de0fa2a. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 23, 2019

Codecov Report

Merging #2131 into master will increase coverage by 0.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2131     +/-   ##
=========================================
+ Coverage   89.39%   89.79%   +0.4%     
=========================================
  Files         170      170             
  Lines       10626    10626             
=========================================
+ Hits         9499     9542     +43     
+ Misses       1127     1084     -43
Impacted Files Coverage Δ
lib/OpenQA/Worker/Engines/isotovideo.pm 94.35% <0%> (+0.51%) ⬆️
lib/OpenQA/WebAPI/Controller/LiveViewHandler.pm 96.46% <0%> (+1.32%) ⬆️
lib/OpenQA/Worker/Jobs.pm 83.39% <0%> (+1.71%) ⬆️
lib/OpenQA/WebAPI/Controller/Developer.pm 100% <0%> (+3.44%) ⬆️
lib/OpenQA/Worker/Common.pm 87.32% <0%> (+3.52%) ⬆️
lib/OpenQA/Scheduler.pm 100% <0%> (+43.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b6d67b...e5ad459. Read the comment docs.

@okurz okurz force-pushed the feature/tests branch 2 times, most recently from 049b42f to ed8e9e6 Compare June 24, 2019 05:17
@okurz okurz changed the title [WIP] Add make target "test-with-database" for easier test database setup Add make target "test-with-database" for easier test database setup Jun 24, 2019
@okurz okurz merged commit 055294f into os-autoinst:master Jul 5, 2019
@okurz okurz deleted the feature/tests branch July 5, 2019 06:55
coolo pushed a commit that referenced this pull request Jul 5, 2019
commit 055294f
Merge: 4487f7a e5ad459
Author:     Oliver Kurz <okurz@suse.de>
AuthorDate: Fri Jul 5 08:55:31 2019 +0200
Commit:     GitHub <noreply@github.com>
CommitDate: Fri Jul 5 08:55:31 2019 +0200

    Merge pull request #2131 from okurz/feature/tests

    Add make target "test-with-database" for easier test database setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants