-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new parameter to support not schedule parent test suite #2224
Conversation
I am not sure if this solution is correct, so I defined it as 'WIP'. There is a problem in it, after creating jobs, the Dependencies (In web UI, the label of jobs detail) does not show the relationship of the parent test suite. I have no idea how to fix it. Should I query the jobs database and set up the last successful job (that is depend on) with the child test suite? |
Codecov Report
@@ Coverage Diff @@
## master #2224 +/- ##
==========================================
+ Coverage 85.81% 85.85% +0.04%
==========================================
Files 162 162
Lines 10738 10742 +4
==========================================
+ Hits 9215 9223 +8
+ Misses 1523 1519 -4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2224 +/- ##
==========================================
+ Coverage 85.88% 85.95% +0.07%
==========================================
Files 164 164
Lines 10803 10807 +4
==========================================
+ Hits 9278 9289 +11
+ Misses 1525 1518 -7
Continue to review full report at Codecov.
|
As e.g.
IMHO it is ok if there is no dependency visualized as there actually are no dependencies between the jobs, only a dependency to the used asset and I am sure that one is still shown in the "Download" tab. |
To be consistent with existed parameters (such as _ONLY_OBSOLETE_SAME_BUILD), I used _SKIP_CHAINED_DEPS as the new parameter. Do you think it is ok? |
Yes, I think this is a good choice, only that your github quoting style is a bit off ;) |
fcf9f3e
to
f8e2c49
Compare
docs/UsersGuide.asciidoc
Outdated
@@ -644,6 +644,8 @@ mean existing jobs for earlier builds with the same DISTRI and VERSION are | |||
no longer interesting, but you still want to be able to re-submit jobs for a | |||
build and have existing jobs for the exact same build obsoleted. | |||
|
|||
_SKIP_CHAINED_DEPS:: Do not trigger parent test suites that specified in START_AFTER_TEST. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/that specified/which are specified/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also don't like the word trigger. It is very unspecific (it has too many different meanings to be meaningful).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changing it to "Do not schedule parent test suites which are specified in START_AFTER_TEST.", is it okay?
c96f0b9
to
eb20521
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK change-wise but your commit message still includes WIP. Want to add more or do you consider your changes ready?
When users use 'client isos post' to schedule test suite, if they specify '_SKIP_CHAINED_DEPS=1', do not schedule parent test suites that defined by 'START_AFTER_TEST'. See: https://progress.opensuse.org/issues/30730
Thanks for the mention. I modified the commit message. |
commit ac734d5 Merge: 59d9cc5 3e1ac84 Author: Oliver Kurz <okurz@suse.de> AuthorDate: Thu Aug 1 11:20:52 2019 +0200 Commit: GitHub <noreply@github.com> CommitDate: Thu Aug 1 11:20:52 2019 +0200 Merge pull request #2224 from Amrysliu/fix_30730 Add a new parameter to support not schedule parent test suite
When users use 'client isos post' to schedule test suite, if they specify
'_NO_TRIGGER_DEPENDENCY=1', do not schedule parent test suites that defined by
'START_AFTER_TEST'.
See: https://progress.opensuse.org/issues/30730