Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle newline characters in form parameters correctly with openqa-client #2272

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

kraih
Copy link
Member

@kraih kraih commented Aug 20, 2019

This makes openqa-client ... jobs/1/comment post $'text=test\n\n123' work. This is now required because proper Markdown requires newlines where previously raw HTML tags like <br> could be used in comments.

Progress: https://progress.opensuse.org/issues/55751

@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #2272 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2272      +/-   ##
==========================================
+ Coverage    86.1%   86.12%   +0.01%     
==========================================
  Files         166      166              
  Lines       10833    10833              
==========================================
+ Hits         9328     9330       +2     
+ Misses       1505     1503       -2
Impacted Files Coverage Δ
lib/OpenQA/Worker/WebUIConnection.pm 81.9% <0%> (-2.52%) ⬇️
lib/OpenQA/Worker/Settings.pm 98.11% <0%> (+13.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9af3c92...621fa0f. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #2272 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2272      +/-   ##
==========================================
+ Coverage    86.1%   86.12%   +0.01%     
==========================================
  Files         166      166              
  Lines       10833    10833              
==========================================
+ Hits         9328     9330       +2     
+ Misses       1505     1503       -2
Impacted Files Coverage Δ
lib/OpenQA/Worker/WebUIConnection.pm 81.9% <0%> (-2.52%) ⬇️
lib/OpenQA/Worker/Settings.pm 98.11% <0%> (+13.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9af3c92...621fa0f. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #2272 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2272      +/-   ##
==========================================
+ Coverage    86.1%   86.12%   +0.01%     
==========================================
  Files         166      166              
  Lines       10833    10833              
==========================================
+ Hits         9328     9330       +2     
+ Misses       1505     1503       -2
Impacted Files Coverage Δ
lib/OpenQA/Worker/WebUIConnection.pm 81.9% <0%> (-2.52%) ⬇️
lib/OpenQA/Worker/Settings.pm 98.11% <0%> (+13.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9af3c92...621fa0f. Read the comment docs.

@kraih kraih merged commit caaab13 into os-autoinst:master Aug 20, 2019
@kraih kraih deleted the client_newline branch May 12, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants