Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish scheduled and blocked jobs on test result overview & Use purple for blocked jobs #2276

Merged
merged 2 commits into from
Aug 22, 2019

Conversation

Martchus
Copy link
Contributor

@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #2276 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2276      +/-   ##
==========================================
- Coverage   86.11%   86.09%   -0.02%     
==========================================
  Files         166      166              
  Lines       10839    10840       +1     
==========================================
- Hits         9334     9333       -1     
- Misses       1505     1507       +2
Impacted Files Coverage Δ
lib/OpenQA/WebAPI/Controller/Test.pm 62.97% <100%> (+0.1%) ⬆️
lib/OpenQA/Worker/Settings.pm 84.9% <0%> (-13.21%) ⬇️
lib/OpenQA/Worker/WebUIConnection.pm 84.42% <0%> (+2.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5609d46...7835a6f. Read the comment docs.

@Martchus
Copy link
Contributor Author

By the way, I don't dare to merge this yet because of the color change (which might be controversial).

@kraih
Copy link
Member

kraih commented Aug 21, 2019

Maybe post a screenshot here to compare before/after. Then everyone can +1/-1. 😉

@Martchus
Copy link
Contributor Author

Martchus commented Aug 21, 2019

screenshot_20190821_181843

It looks similar to scheduled (which makes sense because it is basically just a "special scheduled") but still well distinguishable. And it is also hard to confuse it with red or dark red for failed and incomplete jobs.

@okurz
Copy link
Member

okurz commented Aug 21, 2019

s/Dishinguish/Distinguish/

@okurz
Copy link
Member

okurz commented Aug 21, 2019

But I like the color choice :) you have my approval after you fixed the spelling

@Martchus Martchus changed the title Dishinguish scheduled and blocked jobs on test result overview & Use purple for blocked jobs Distinguish scheduled and blocked jobs on test result overview & Use purple for blocked jobs Aug 22, 2019
Copy link
Member

@kalikiana kalikiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@okurz okurz merged commit 5f4e21f into os-autoinst:master Aug 22, 2019
@Martchus Martchus deleted the blocked_by_overview branch August 22, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants