Use a new file to exchange status with isotovideo (isotovideo process might already be finished at query time) #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlpunk
force-pushed
the
new-status
branch
3 times, most recently
from
8a0e075
to
821a0f7
Compare
perlpunk
force-pushed
the
new-status
branch
from
821a0f7
to
c6923dd
Compare
Codecov Report
@@ Coverage Diff @@
## master #2327 +/- ##
==========================================
- Coverage 87.22% 87.14% -0.09%
==========================================
Files 169 169
Lines 11078 11083 +5
==========================================
- Hits 9663 9658 -5
- Misses 1415 1425 +10
Continue to review full report at Codecov.
|
perlpunk
force-pushed
the
new-status
branch
4 times, most recently
from
9ba080e
to
0faec49
Compare
perlpunk
force-pushed
the
new-status
branch
2 times, most recently
from
42310ae
to
489ad58
Compare
perlpunk
changed the title
perlpunk
force-pushed
the
new-status
branch
2 times, most recently
from
0af5a6d
to
394385b
Compare
perlpunk
force-pushed
the
new-status
branch
4 times, most recently
from
6f421f9
to
323f592
Compare
kraih
reviewed
Oct 23, 2019
kraih
reviewed
Oct 23, 2019
kraih
reviewed
Oct 23, 2019
kraih
approved these changes
Oct 23, 2019
okurz
approved these changes
Oct 23, 2019
|
the description still mentions "Work in progress"? |
|
Rebased and squashed, removed WIP from description |
Martchus
approved these changes
Oct 24, 2019
kalikiana
approved these changes
Oct 24, 2019
|
@perlpunk Can you try and rebase? Seems like OBS got stuck, other PRs are fine. |
Remove 'backend' entry from status hash: this was always empty Remove mocking of OpenQA::Worker::Isotovideo::Client
perlpunk
added a commit
to perlpunk/os-autoinst
that referenced
this pull request
Oct 25, 2019
The status API call is not used anymore since: os-autoinst#1212 It is now writing a status file. The corresponding PR in openQA to use the status file: os-autoinst/openQA#2327 Issue: https://progress.opensuse.org/issues/39845
perlpunk
added a commit
to perlpunk/os-autoinst
that referenced
this pull request
Dec 10, 2019
The status API call is not used anymore since: os-autoinst#1212 It is now writing a status file. The corresponding PR in openQA to use the status file: os-autoinst/openQA#2327 Issue: https://progress.opensuse.org/issues/39845
perlpunk
added a commit
to perlpunk/os-autoinst
that referenced
this pull request
May 14, 2020
The status API call is not used anymore since: os-autoinst#1212 It is now writing a status file. The corresponding PR in openQA to use the status file: os-autoinst/openQA#2327 Issue: https://progress.opensuse.org/issues/39845
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results for tests running less than 10 seconds aren't displayed in the webui, and the job is marked as failed.
This happens because the status call to isotovideo is happening too late, when isotovideo is already finished, so it doesn't get anything back.
Instead we are reading the status from a file that will survive the isotovideo process.
See os-autoinst/os-autoinst#1212
Depends on os-autoinst/os-autoinst#1212
See also: