-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish OSB plugin #2333
Polish OSB plugin #2333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleaner indeed, especially the use of Mojo::DOM
for XML parsing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except the sort keys
issue.
These links wouldn't work anyways. Browsing into the nested directory structure needed to be implemented first.
eecb1cd
to
95e8ad3
Compare
I've tried this and Plugin UI looks really mature now, thank you! |
Codecov Report
@@ Coverage Diff @@
## master #2333 +/- ##
==========================================
- Coverage 86.94% 86.89% -0.06%
==========================================
Files 168 168
Lines 11139 11139
==========================================
- Hits 9685 9679 -6
- Misses 1454 1460 +6
Continue to review full report at Codecov.
|
See particular commit messages