Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish OSB plugin #2333

Merged
merged 4 commits into from
Sep 18, 2019
Merged

Conversation

Martchus
Copy link
Contributor

See particular commit messages

lib/OpenQA/WebAPI/Plugin/ObsRsync.pm Outdated Show resolved Hide resolved
t/ui/27-plugin_obs_rsync_obs_status.t Outdated Show resolved Hide resolved
Copy link
Member

@kraih kraih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaner indeed, especially the use of Mojo::DOM for XML parsing.

lib/OpenQA/WebAPI/Plugin/ObsRsync.pm Outdated Show resolved Hide resolved
Copy link
Contributor

@perlpunk perlpunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except the sort keys issue.

@os-autoinst os-autoinst deleted a comment from codecov bot Sep 18, 2019
@andrii-suse
Copy link
Contributor

I've tried this and Plugin UI looks really mature now, thank you!

@andrii-suse andrii-suse self-requested a review September 18, 2019 11:56
@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #2333 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2333      +/-   ##
==========================================
- Coverage   86.94%   86.89%   -0.06%     
==========================================
  Files         168      168              
  Lines       11139    11139              
==========================================
- Hits         9685     9679       -6     
- Misses       1454     1460       +6
Impacted Files Coverage Δ
...penQA/WebAPI/Plugin/ObsRsync/Controller/Folders.pm 100% <100%> (ø) ⬆️
lib/OpenQA/WebAPI/Plugin/ObsRsync.pm 96.66% <100%> (ø) ⬆️
lib/OpenQA/Worker/WebUIConnection.pm 78.09% <0%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c377d78...95e8ad3. Read the comment docs.

@Martchus Martchus merged commit e34f50d into os-autoinst:master Sep 18, 2019
@Martchus Martchus deleted the use-mojo-dom-in-obs-plugin branch September 18, 2019 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants