Load build results on dashboard via AJAX #2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
reviewed
Sep 27, 2019
Martchus
force-pushed
the
dashboard-ajax
branch
from
b264445
to
e0cb63c
Compare
okurz
reviewed
Sep 28, 2019
So it works like the dashboard on GitHub. Additionally, when submitting the filter form the whole page doesn't need to reload anymore. See https://progress.opensuse.org/issues/55112
Martchus
force-pushed
the
dashboard-ajax
branch
from
e0cb63c
to
6224175
Compare
okurz
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it works like the dashboard on GitHub. Additionally, when submitting the filter form the whole page doesn't need to reload anymore.
See https://progress.opensuse.org/issues/55112
This was quite easy. I guess adapting the tests will be the annoying part.
Note that the
.jsonrepresentation of the index page (which is not considered part of openQA's stable API) is removed by this change but the same info is now available via/dashboard_build_results.json.