Retry limit asset tasks on key constraint violations #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These errors are mostly caused by race conditions but we want to avoid locking the tables, see https://progress.opensuse.org/issues/57287#note-3. Note that none of the logic within the try block changed.
Codecov Report
@@ Coverage Diff @@
## master #2360 +/- ##
==========================================
+ Coverage 86.93% 87.01% +0.07%
==========================================
Files 168 168
Lines 11184 11191 +7
==========================================
+ Hits 9723 9738 +15
+ Misses 1461 1453 -8
Continue to review full report at Codecov.
|
coolo
pushed a commit
that referenced
this pull request
Oct 1, 2019
commit 7d662d3 Merge: 683ca66 ce52281 Author: Oliver Kurz <okurz@suse.de> AuthorDate: Tue Oct 1 06:22:53 2019 +0200 Commit: GitHub <noreply@github.com> CommitDate: Tue Oct 1 06:22:53 2019 +0200 Merge pull request #2360 from Martchus/retry-on-limit-asset-constraint-violation Retry limit asset tasks on key constraint violations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make t/37-limit_assets.t independent of t/14-grutasks.t
Retry limit asset job on key constraint violations
These errors are mostly caused by race conditions but we want to avoid locking the tables, see https://progress.opensuse.org/issues/57287#note-3.
Note that none of the logic within the try block changed.