don't invent running states if the module is not yet running #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -302,7 +308,7 @@ sub read_json_file { | |||
| my $fn = "$pooldir/testresults/$name"; | |||
| my $ret; | |||
| local $/; | |||
| open(my $fh, '<', $fn) or return undef; | |||
| open(my $fh, '<', $fn) or die "can't open $fn: $!"; | |||
There was a problem hiding this comment.
Won't this potentially trigger dead workers when i.e. canceling job before isotovideo fully initialize? Are all json files guaranteed to be present to warrant this death order?
There was a problem hiding this comment.
you're right. I changed it to a warn
coolo
added a commit
that referenced
this pull request
Mar 10, 2015
don't invent running states if the module is not yet running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.