Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Reduce use of project dir to be more flexible regarding custom test runs" #2433

Closed
wants to merge 1 commit into from

Conversation

okurz
Copy link
Member

@okurz okurz commented Oct 24, 2019

Reverts #2410 due to problems as described in https://progress.opensuse.org/issues/56789#note-23

@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #2433 into master will decrease coverage by 0.08%.
The diff coverage is 75.4%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2433      +/-   ##
==========================================
- Coverage   87.22%   87.14%   -0.09%     
==========================================
  Files         169      169              
  Lines       11078    11089      +11     
==========================================
  Hits         9663     9663              
- Misses       1415     1426      +11
Impacted Files Coverage Δ
lib/OpenQA/Worker/Engines/isotovideo.pm 93.83% <100%> (+0.02%) ⬆️
lib/OpenQA/WebAPI/Controller/File.pm 91.66% <100%> (+0.26%) ⬆️
lib/OpenQA/Schema/Result/JobModules.pm 82.78% <14.28%> (-2.69%) ⬇️
lib/OpenQA/Schema/Result/Needles.pm 66.66% <50%> (-4.42%) ⬇️
lib/OpenQA/WebAPI/Controller/Step.pm 62.73% <84.61%> (-2.22%) ⬇️
lib/OpenQA/Utils.pm 92.45% <86.66%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba31da2...7d34a7b. Read the comment docs.

@okurz
Copy link
Member Author

okurz commented Oct 24, 2019

@Martchus as I encountered problems in production when going back to the old packages as reported in the discussed ticket I leave it to your discretion to decide if we should merge this revert or have a fix which you already prepared in #2432

@Martchus
Copy link
Contributor

I'll continue working on the fix. To which version did you downgrade production? Maybe something was downgraded inconsistently?

@Martchus
Copy link
Contributor

I see why the problem wasn't solved by downgrading: The required part of this revert lies on the worker but according to your comment in the ticket you only downgraded the web UI.

@Martchus Martchus closed this Oct 25, 2019
@Martchus Martchus deleted the revert-2410-needles-dir branch October 25, 2019 09:47
@okurz
Copy link
Member Author

okurz commented Oct 28, 2019

@Martchus no, I had also downgraded the worker. I assumed a problem might be if I just clone old jobs with already initialized settings which could set different, unsupported values, e.g. for PRJDIR and such

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants