-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying to get a grip on our worker->webui bandwidth: #246
Conversation
- only upload log and screenshot if livelog is wanted - only update status if there is some, e.g. stay silent if nothing to say - upload only the md5sum of the images and wait for the webui to tell the worker which of these md5sums it already knows - upload uknown images one by one to avoid long wait times for other workers/users - these images are stored in /var/lib/openqa/images under their md5 and the testresults only get a symlink
looks fine to me. I don't know who and when need to call migrate_images/optimize_images though |
in the next DB migration we add, we can move the migrate_images into common. For now I would call it manually when deploying. optimize_images supposed to be a cron job, I guess we can package that one too |
I like the idea of symlinking md5-named screenshots. It is good to save bandwidth and storage with different testruns possibly producing identical images. |
manual ref counting for cleaning is not so hard to implement :) |
actually we don't remove testresults at all at this point |
}; | ||
# don't use api_call as it retries and does not allow form data | ||
# (refactor at some point) | ||
$OpenQA::Worker::Common::ua->post($ua_url => form => $form); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we really need an api_call that can handle form data
Trying to get a grip on our worker->webui bandwidth:
fixing the package now |
to say
to tell the worker which of these md5sums it already knows
workers/users
md5 and the testresults only get a symlink