Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to get a grip on our worker->webui bandwidth: #246

Merged
merged 1 commit into from
Mar 11, 2015
Merged

Conversation

coolo
Copy link
Contributor

@coolo coolo commented Mar 10, 2015

  • only upload log and screenshot if livelog is wanted
  • only update status if there is some, e.g. stay silent if nothing
    to say
  • upload only the md5sum of the images and wait for the webui
    to tell the worker which of these md5sums it already knows
  • upload uknown images one by one to avoid long wait times for other
    workers/users
  • these images are stored in /var/lib/openqa/images under their
    md5 and the testresults only get a symlink

- only upload log and screenshot if livelog is wanted
- only update status if there is some, e.g. stay silent if nothing
  to say
- upload only the md5sum of the images and wait for the webui
  to tell the worker which of these md5sums it already knows
- upload uknown images one by one to avoid long wait times for other
  workers/users
- these images are stored in /var/lib/openqa/images under their
  md5 and the testresults only get a symlink
@nilxam
Copy link
Member

nilxam commented Mar 11, 2015

looks fine to me. I don't know who and when need to call migrate_images/optimize_images though

@coolo
Copy link
Contributor Author

coolo commented Mar 11, 2015

in the next DB migration we add, we can move the migrate_images into common. For now I would call it manually when deploying.

optimize_images supposed to be a cron job, I guess we can package that one too

@bmwiedemann
Copy link
Contributor

I like the idea of symlinking md5-named screenshots. It is good to save bandwidth and storage with different testruns possibly producing identical images.
The downside is, that it will be hard to find out when it is OK to clean up a file (needs manual reference counting). Hardlinks would have the filesystem do the link-counting, possibly with other downsides, such as a maximum number of links.
Or we just do find -mtime +30 for cleanup...

@coolo
Copy link
Contributor Author

coolo commented Mar 11, 2015

manual ref counting for cleaning is not so hard to implement :)

@coolo
Copy link
Contributor Author

coolo commented Mar 11, 2015

actually we don't remove testresults at all at this point

};
# don't use api_call as it retries and does not allow form data
# (refactor at some point)
$OpenQA::Worker::Common::ua->post($ua_url => form => $form);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we really need an api_call that can handle form data

lnussel added a commit that referenced this pull request Mar 11, 2015
Trying to get a grip on our worker->webui bandwidth:
@lnussel lnussel merged commit 23d31ed into master Mar 11, 2015
@coolo coolo deleted the issue_6496 branch March 11, 2015 09:47
@coolo
Copy link
Contributor Author

coolo commented Mar 11, 2015

fixing the package now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants