Show machine in dependency graph #2477
Conversation
|
|
||
| my $test = $self->TEST; | ||
| my $machine = $self->MACHINE; | ||
| return $machine ? "$test\@$machine" : $test; |
There was a problem hiding this comment.
how can we have not a machine?
There was a problem hiding this comment.
The code a few lines above in sub name implies that MACHINE is optional. There are also various other places, e.g. sub latest_jobs where MACHINE is optional while most other settings are mandatory. So I made this consistent with most other places in openQA. But there are indeed a few places where we expect machine to be present. Do you want me to fix all places to assume MACHINE is always present?
There was a problem hiding this comment.
well, the iso controller surely won't create jobs without MACHINE - possibly the jobs controller allows that? Jobs created through that, won't have dependencies though :)
If you required it, you would have to pick one in the jobs controller - so having it optional might be easy enough.
There was a problem hiding this comment.
Jobs created through the jobs controller can have dependencies. The clone job script makes use of this. And after a brief look it doesn't seem to require MACHINE which is by the way nullable
MACHINE => {
data_type => 'text',
is_nullable => 1
},
in contrast to other variables which are either mandatory like
TEST => {
data_type => 'text'
},
or by default empty, e.g.
DISTRI => {
data_type => 'text',
default_value => ''
},
.
Codecov Report
@@ Coverage Diff @@
## master #2477 +/- ##
==========================================
- Coverage 87.05% 87.03% -0.03%
==========================================
Files 168 168
Lines 11016 11020 +4
==========================================
+ Hits 9590 9591 +1
- Misses 1426 1429 +3
Continue to review full report at Codecov.
|
See https://progress.opensuse.org/issues/59082