Include external reporting template for parsed results too #2506
Conversation
marmarek
force-pushed
the
parser-external-reporting
branch
3 times, most recently
from
4faa401
to
e44c2a7
Compare
There was a problem hiding this comment.
Hi @marmarek , welcome back :)
Regarding your question of using a custom branding. You can set a value within /etc/openqa/openqa.ini and you can put branding files within /etc/openqa/templates with the same relative path as within /usr/share/openqa/templates which can override templates or provide some for brandings that do not exist in the main source tree.
That's weird, as my initial commit (see force-push history; EDIT: oh, github shows only diff for the last one...) definitely caused some test failures, so it was executed in some of the tests. Is test coverage measured only on a subset of the tests? |
|
the external branding is certainly not covered by any coverage tests but your other changes should be covered. I wouldn't worry about it though. I could not find any test failures in your previous commit but only the same coverage missing check that failed there. |
|
The previous failure is here: https://circleci.com/gh/os-autoinst/openQA/6066 |
This will be useful for calling bug_report_actions in module_table.html.ep, where test module and step are not stashed.
Allow branding to set external reporting link to parsed results too. Since parsed results are all rendered as part of a single template, module and step id needs to be set directly in a template during the iteration. And branding template modified to actually use those values.
marmarek
force-pushed
the
parser-external-reporting
branch
from
e44c2a7
to
20b612a
Compare
|
Done the changes:
The second one I've done in a generic way (any arguments as passed down to the template). If you prefer to explicitly name just module and step id, let me know. |
* Move floating action icons before the text * Increase padding around action icons a little bit (in consistency with help icon)
|
@marmarek Thanks for changing it according to my suggestions. I've also added a commit to tweak the markup/styling a little bit. I guess that's more efficient than explaining it (see the commit message for details). |
|
I reported https://progress.opensuse.org/issues/60035 for the unrelated OBS check failure in plugin_obs_rsync_async |
Allow branding to set external reporting link to parsed results too.
Since parsed results are all rendered as part of a single template,
module and step id needs to be set directly in a template during
the iteration. And branding template modified to actually use those
values.
I'm not an expert in CSS, and this is the best I can do - the action link is at the bottom right of expanded parsed result text. If anyone know how to put it at the top right (but not increasing height of the collapsed row), that would be more consistent with other places.
You can see how it looks now here: https://openqa.qubes-os.org/tests/4710#step/QubeManagerTest/69
I've included changes to openSUSE branding, but in fact I've tested it on a Qubes OS one (not published yet). BTW is there a way to load branding from an alternative directory?