Increase SQLite busy timeout and reduce the number of SQLite connections #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martchus
approved these changes
Nov 29, 2019
Codecov Report
@@ Coverage Diff @@
## master #2559 +/- ##
==========================================
- Coverage 91.48% 91.47% -0.01%
==========================================
Files 181 181
Lines 11187 11180 -7
==========================================
- Hits 10234 10227 -7
Misses 953 953
Continue to review full report at Codecov.
|
openqabot
pushed a commit
to openqabot/openQA
that referenced
this pull request
Nov 30, 2019
commit ce9ba48 Merge: c9e9406 61d8d3f Author: Sebastian Riedel <sri@cpan.org> AuthorDate: Fri Nov 29 17:12:19 2019 +0100 Commit: GitHub <noreply@github.com> CommitDate: Fri Nov 29 17:12:19 2019 +0100 Merge pull request os-autoinst#2559 from kraih/sqlite_locks Increase SQLite busy timeout and reduce the number of SQLite connections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the SQLite busy timeout from 30 seconds to 5 minutes. That should give slower operations like Minion queue repairs enough time to finish even on very slow workers. I've also removed the explicit
exclusivelocks, since we only perform a single query in every case, and those will automatically acquire the lock they need. And finally each process will now only use one SQLite connection.All of this should be enough to resolve the problems we had with jobs getting stuck and the cache service dying.
Progress: https://progress.opensuse.org/issues/58484