-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add silent reload of dashboard contents for fullscreen mode #2684
Conversation
The commit message "Silent index autoreload of for dashboard use" is not nice. I would it rephrase as "Add silent reload of dashboard contents for fullscreen mode". |
Would be nice but checks in OBS fail currently. We should only merge on green test results |
Could you please use an approach that is compatible with 2b3885a as described in https://progress.opensuse.org/issues/17886 so that we do not have two refresh features? |
I don's see how that code could be reused in a valuable way. It would only create spaghetty code to mix index.js and fullscreen.js. |
Codecov Report
@@ Coverage Diff @@
## master #2684 +/- ##
==========================================
- Coverage 91.94% 91.83% -0.11%
==========================================
Files 184 184
Lines 11589 11589
==========================================
- Hits 10655 10643 -12
- Misses 934 946 +12
Continue to review full report at Codecov.
|
Rebased to current master to retrigger testsuite. |
To reuse or merge with existing auto-refresh code we needed to port the group overview to using AJAX first. Both auto-refresh approaches are just a few lines of code so I wouldn't overthink it. |
sure, I agree. However I think the parameter is quite hidden. Can we add it to some help-text on the page? |
Yes, it is hidden. A better alternative would be adding a from element (like we already have for the fullscreen parameter) with a help-text. If it is good enough for @asdil12 as it is I wouldn't make that improvement mandatory for merging the PR. Note that the fullscreen and interval parameters are so far also completely hidden on the group overview and the timeago rendering is broken on the group overview when setting the interval. So there's generally room for improvement. |
fine. Martchus will cover the missing steps in the mentioned ticket. |
This will allow setting the get parameter
interval
to a value of seconds after which the index page is reloaded - but without loading indicator to always show results.This is intended for dashboard usage.