load_templates: better error handling #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalikiana
force-pushed
the
load_templates_perm
branch
from
b036e63
to
4a0d791
Compare
andrii-suse
reviewed
Jan 24, 2020
andrii-suse
reviewed
Jan 24, 2020
kalikiana
force-pushed
the
load_templates_perm
branch
2 times, most recently
from
f1dc7b8
to
2094c21
Compare
kalikiana
force-pushed
the
load_templates_perm
branch
from
2094c21
to
8805db2
Compare
andrii-suse
reviewed
Jan 31, 2020
|
+1 |
kalikiana
force-pushed
the
load_templates_perm
branch
from
8805db2
to
a6b0414
Compare
- The unit test also runs a webui with fixtures to verify how templates are loaded and how errors are handled. - SeleniumTest::start_app is re-based onto OpenQA::TEST::Utils::create_webapi since both do the same except the latter was missing the schema hook. - Fail cleanly in JobTemplate::update if not template was specified. - Make Selenium start helpers internal
kalikiana
force-pushed
the
load_templates_perm
branch
from
a6b0414
to
ea61649
Compare
Codecov Report
@@ Coverage Diff @@
## master #2690 +/- ##
==========================================
+ Coverage 91.97% 91.98% +<.01%
==========================================
Files 187 187
Lines 11708 11709 +1
==========================================
+ Hits 10768 10770 +2
+ Misses 940 939 -1
Continue to review full report at Codecov.
|
okurz
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SeleniumTest::start_appis re-based ontoOpenQA::TEST::Utils::create_webapisince both do the same except the latter was missing the schema hook.JobTemplate::updateif not template was specified.Related to: poo#60118