Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap: Install required dep qemu-tools #2809

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

asdil12
Copy link
Member

@asdil12 asdil12 commented Mar 3, 2020

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #2809 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2809      +/-   ##
==========================================
- Coverage   92.22%   92.12%   -0.11%     
==========================================
  Files         190      190              
  Lines       11810    11810              
==========================================
- Hits        10892    10880      -12     
- Misses        918      930      +12
Impacted Files Coverage Δ
lib/OpenQA/Scheduler/Model/Jobs.pm 88.66% <0%> (-2.84%) ⬇️
lib/OpenQA/Worker/WebUIConnection.pm 85.33% <0%> (-2.23%) ⬇️
lib/OpenQA/WebAPI/Controller/API/V1/Job.pm 87.92% <0%> (-2.17%) ⬇️
lib/OpenQA/Worker/CommandHandler.pm 78.63% <0%> (-1.71%) ⬇️
lib/OpenQA/Worker/Job.pm 72.43% <0%> (+0.32%) ⬆️
lib/OpenQA/Worker/Settings.pm 98.11% <0%> (+13.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81587c9...9356891. Read the comment docs.

@okurz
Copy link
Member

okurz commented Mar 3, 2020

Just to make this clear: As we install qemu I think it also makes sense to pull in qemu-tools. That we have this manually maintained list of packages in bootstrap itself is questionable in general. IMHO it is more likely that "openqa-bootstrap" is used in a setup when wants to run a local worker and hence qemu but still not necessarily what the user wants.

@okurz okurz merged commit 87d189d into os-autoinst:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants