Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openqa-clone-custom-git-refspec: Add option to pass clone-job arguments #2810

Merged
merged 2 commits into from
Mar 4, 2020

Conversation

okurz
Copy link
Member

@okurz okurz commented Mar 3, 2020

@okurz
Copy link
Member Author

okurz commented Mar 3, 2020

@perlpunk @ggardet ok like this?

@okurz okurz force-pushed the feature/clone_custom_args branch from c0c58e3 to 4973430 Compare March 3, 2020 17:18
@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #2810 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2810      +/-   ##
==========================================
- Coverage   92.28%   92.11%   -0.17%     
==========================================
  Files         190      190              
  Lines       11840    11840              
==========================================
- Hits        10926    10907      -19     
- Misses        914      933      +19     
Impacted Files Coverage Δ
lib/OpenQA/Worker/WebUIConnection.pm 85.33% <0.00%> (-3.12%) ⬇️
lib/OpenQA/Scheduler/Model/Jobs.pm 88.66% <0.00%> (-2.84%) ⬇️
lib/OpenQA/WebAPI/Controller/API/V1/Job.pm 87.92% <0.00%> (-1.55%) ⬇️
lib/OpenQA/Worker/Job.pm 72.10% <0.00%> (-1.15%) ⬇️
lib/OpenQA/Worker/Settings.pm 98.11% <0.00%> (+13.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87d189d...4973430. Read the comment docs.

@okurz okurz merged commit e569a94 into os-autoinst:master Mar 4, 2020
@okurz okurz deleted the feature/clone_custom_args branch March 4, 2020 11:51
@ggardet
Copy link
Contributor

ggardet commented Mar 9, 2020

Sorry, I was away last week. Thanks for this PR which LGTM.

@okurz
Copy link
Member Author

okurz commented Mar 9, 2020

Thank you! Feedback at any time is welcome. Even late feedback is better than no feedback :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants