Make parameters for splitting screenshot cleanup configurable #2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
reviewed
Mar 10, 2020
Martchus
force-pushed
the
make-job-splitting-params-configurable
branch
from
144399d
to
2683b61
Compare
Codecov Report
@@ Coverage Diff @@
## master #2821 +/- ##
==========================================
+ Coverage 92.42% 92.48% +0.05%
==========================================
Files 190 190
Lines 11889 11889
==========================================
+ Hits 10989 10996 +7
+ Misses 900 893 -7
Continue to review full report at Codecov.
|
okurz
approved these changes
Mar 11, 2020
On different production instances the runtime of the splitted cleanup tasks differs a lot so it makes sense to make the parameters for splitting configurable. See https://progress.opensuse.org/issues/55922#note-18
Martchus
force-pushed
the
make-job-splitting-params-configurable
branch
from
2683b61
to
ae884a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On different production instances the runtime of the splitted cleanup tasks differs a lot so it makes sense to make the parameters for splitting configurable.
See https://progress.opensuse.org/issues/55922#note-18