Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing method import "find_bug_number" #2906

Merged
merged 1 commit into from Apr 6, 2020

Conversation

okurz
Copy link
Member

@okurz okurz commented Apr 6, 2020

@kraih
Copy link
Member

kraih commented Apr 6, 2020

There would have to be a serious hole in our test coverage for this to happen.

@okurz
Copy link
Member Author

okurz commented Apr 6, 2020

yes, @kalikiana will look into the missing coverage

Copy link
Member

@kalikiana kalikiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aye, I'll plug the hole in our coverage. In the meantime the fix looks good. Thanks @okurz

@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #2906 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2906      +/-   ##
==========================================
- Coverage   93.34%   93.34%   -0.01%     
==========================================
  Files         189      189              
  Lines       11931    11928       -3     
==========================================
- Hits        11137    11134       -3     
  Misses        794      794              
Impacted Files Coverage Δ
lib/OpenQA/Schema/Result/Needles.pm 96.42% <100.00%> (ø)
lib/OpenQA/WebAPI/Controller/File.pm 96.15% <100.00%> (-0.04%) ⬇️
lib/OpenQA/WebAPI/Controller/Step.pm 92.43% <100.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94bcc1c...3d05b5b. Read the comment docs.

@okurz okurz merged commit 786b5e7 into os-autoinst:master Apr 6, 2020
@okurz okurz deleted the fix/bug_number branch April 6, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants