Improve test for preserving pending assets #2910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
reviewed
Apr 6, 2020
* Previously the test didn't really work, e.g. when breaking the condition in OpenQA::Schema::ResultSet::Assets::status the test still passed * Now the test checks whether the asset is deleted if when the job is not pending anymore to see whether the pending state actually makes a difference (and the test setup is correct) * See https://progress.opensuse.org/issues/64544 (it does not fix that issue but problems with the test became apparent when investigating it)
Codecov Report
@@ Coverage Diff @@
## master #2910 +/- ##
=======================================
Coverage 93.35% 93.35%
=======================================
Files 190 190
Lines 11955 11955
=======================================
Hits 11161 11161
Misses 794 794 Continue to review full report at Codecov.
|
okurz
approved these changes
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in OpenQA::Schema::ResultSet::Assets::status the test still passed
not pending anymore to see whether the pending state actually makes a
difference (and the test setup is correct)
issue but problems with the test became apparent when investigating
it)