t: Stabilize ui/10-tests_overview.t #2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2949 +/- ##
=======================================
Coverage 93.45% 93.45%
=======================================
Files 190 190
Lines 11961 11961
=======================================
Hits 11178 11178
Misses 783 783 Continue to review full report at Codecov.
|
okurz
force-pushed
the
fix/tests_overview_test
branch
from
e16ce7e
to
bc572ce
Compare
Martchus
reviewed
Apr 16, 2020
This fixes "Failed test 'description popover shows content' at t/ui/10-tests_overview.t line 168." that we see often recently. Probably reading the description is a tad slower but the test was not taking the popup time into account anyway so this should be fixed.
okurz
force-pushed
the
fix/tests_overview_test
branch
from
bc572ce
to
2523b39
Compare
Martchus
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes "Failed test 'description popover shows content' at
t/ui/10-tests_overview.t line 168." that we see often recently. Probably
reading the description is a tad slower but the test was not taking the
popup time into account anyway so this should be fixed.