Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exit code returned by client #2991

Merged
merged 1 commit into from Apr 25, 2020
Merged

Conversation

okurz
Copy link
Member

@okurz okurz commented Apr 25, 2020

Fixes a problem introduced with 5c9068a.

@okurz
Copy link
Member Author

okurz commented Apr 25, 2020

Currently products are not correctly synced on o3. See https://progress.opensuse.org/issues/66060 . Maybe this has something to do with the wrong exit code of the client script? I pulled out that fix from #2985 as that PR does not have approval yet and I will merge this PR as soon as checks are finished. I hope everyone is ok with that in an effort to fix the problem soon.

@perlpunk
Copy link
Contributor

https://github.com/okurz/openQA/blob/fix/client/lib/OpenQA/Client.pm#L87
Shouldn't this line now be: return undef; ?

@okurz
Copy link
Member Author

okurz commented Apr 25, 2020

yes, of course. Thx. Fixed.

Fixes a problem introduced with 5c9068a.
@okurz okurz merged commit 75468e7 into os-autoinst:master Apr 25, 2020
@okurz okurz deleted the fix/client branch April 25, 2020 13:56
@okurz
Copy link
Member Author

okurz commented Apr 25, 2020

@perlpunk thanks for your support. This annoying UI test prevented my auto-merge :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants