Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t: Make process handling more robust with IPC::Run #3123

Merged
merged 1 commit into from May 29, 2020

Commits on May 28, 2020

  1. t: Make process handling more robust with IPC::Run

    Whenever processes are spawned they need to be tracked properly for
    cleanup. This posed problems of sometimes leaking orphans when tests are
    aborted or crashed. As we already use IPC::Run we can use the same for
    other cases where we spawn processes with fork by using IPC::Run::start
    instead. Additional benefits are that we can debug the process handling
    and IPC going with https://metacpan.org/pod/IPC::Run#Debugging-Tip as
    well as be able to catch output of the processes.
    
    One example of a recent problem that should be fixed by this is
    t/05-scheduler-full.t failing to stop completely when individual test
    steps fail. This prevents the RETRY on the level of tools/retry and the
    Makefile to work as the former test never completely finishes and is
    stuck until the CI aborts the complete test run without further retries.
    
    https://progress.opensuse.org/issues/59043
    okurz committed May 28, 2020
    Copy the full SHA
    7285b1a View commit details
    Browse the repository at this point in the history