Prevent schedule from being reread unnecessarily #3183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
reviewed
Jun 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #3183 +/- ##
=======================================
Coverage 91.98% 91.98%
=======================================
Files 211 211
Lines 12931 12933 +2
=======================================
+ Hits 11894 11896 +2
Misses 1037 1037
Continue to review full report at Codecov.
|
perlpunk
force-pushed
the
schedule-reload
branch
from
906dcb3
to
c2363a6
Compare
|
I added a test |
This can happen if a test is finished and the new one hasn't started. (Reproduce by adding a `sleep 10` in basetest.pm after `$self->done()`. The backend will report an empty `$running_test`, and in this case `$current_test_module` should keep its last value. It will also reduce payload of the status posts, because it previously posted the status of *all* tests when `$current_test_module` was empty. This also fixes the issue that results of short tests < 10s are only reported at the end of the job. Related Issues: * https://progress.opensuse.org/issues/58826 * https://progress.opensuse.org/issues/58700 * https://progress.opensuse.org/issues/67972
perlpunk
force-pushed
the
schedule-reload
branch
from
c2363a6
to
64caa7a
Compare
Amrysliu
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen if a test is finished and the new one hasn't started.
(Reproduce by adding a
sleep 10in basetest.pm after$self->done().The backend will report an empty
$running_test, and in this case$current_test_moduleshould keep its last value.It will also reduce payload of the status posts, because it previously posted
the status of all tests when
$current_test_modulewas empty.This also fixes the issue that results of short tests < 10s are only
reported at the end of the job.
Related Issues: