introduce Gru plugin #323
introduce Gru plugin #323
Conversation
|
it should be noted that once this is in, factory/iso need to be owned by geekotest as the gru user is then responsible for cleanup. |
coolo
force-pushed
the
coolo_issue_6956
branch
2 times, most recently
from
5c7ed69
to
6e64c5a
Compare
| } | ||
|
|
||
| sub add_task { | ||
| ($_[0]->{tasks}->{$_[1]} = $_[2]) and return $_[0]; |
There was a problem hiding this comment.
You're doing a bad name for perl :D
There was a problem hiding this comment.
that's what you get when copying from mojo code :)
|
I made the code a bit clearer in c44e9cf - but the test suite fails now for reasons I don't get |
it's inspired by minion plugin but puts the tasks in our database without further requirements - replacing optimize_images with gru tasks - queue a task to reduce test results after 14 days
|
found the problem (hopefully without introducing another :) |
| $c->run('run', '-o'); | ||
|
|
||
| is(1, -f "t/data/openqa/factory/iso/openSUSE-13.1-DVD-i586-Build0091-Media.iso", "iso 1 is still there"); | ||
| is(1, -f "t/data/openqa/factory/iso/openSUSE-13.1-DVD-x86_64-Build0091-Media.iso", "iso 2 is still there"); |
There was a problem hiding this comment.
Can't you use ok(..) instead? I was wondering about travis results why it expects undef and then noticed you switched tested and expected result. Took like 5mins form my life :)
There was a problem hiding this comment.
fine with me - rewrote history, so you got your 5 mins back :)
For this I added a size column to the asset table as cache
(at least to those able to talk SQL :)
|
@nadvornik created_by is in |
|
LGTM, but my hoarding complex does not like 14 day expiration. Use case probably not relevant for opensuse testing, but i.e. back then when autotesting autoyast the tests were triggered automatically when new iso was published. Now it was during summer holidays, people were off for weeks so checking older results was common. |
|
well, it's configurable |
|
I merged this now and 20d032c giving a default of 30 days |
it's inspired by minion plugin but puts the tasks in our database
without further requirements