Make prove aware of timeout #3281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3281 +/- ##
==========================================
- Coverage 91.49% 91.48% -0.02%
==========================================
Files 215 215
Lines 13052 13052
==========================================
- Hits 11942 11940 -2
- Misses 1110 1112 +2
Continue to review full report at Codecov.
|
okurz
reviewed
Jul 23, 2020
- timeout -s SIGINT specifies the signal to send - prove --trap records test results on SIGINT Fixes: https://progress.opensuse.org/issues/69148
This is a fallback in case the process doesn't exit after the orginal timeout specified with -v.
kalikiana
force-pushed
the
prove_timeout_sigint
branch
from
077eaa3
to
ff2f2d6
Compare
Martchus
approved these changes
Jul 24, 2020
|
keep in mind that I haven't actually seen a proof that this really fixes the issue as that would need a circleci job running into timeout but then still being able to show result details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make prove aware of the fact that
timeoutkills it before it can record the results using --trap and -s SIGINT -k 5. This allows results to be recorded. There is a fallback timeout in case the process doesn't exit after that.Fixes: poo#69148